From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id BCF383CB35 for ; Wed, 23 Oct 2019 17:09:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571864955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p2Bt+TeFORfohjlF3bqI3+Mu+yeYbBVrSueSOmuZILw=; b=C17HvBsKF3pWU4ksRLL30s15NOiJ34aagRK54qYRf40i4X0wCtkvM5gSwY84kPBBvkFEsp 6gKuYsYqxjpvpEp3gDou3uDG6/+t+7xCFy/jiE8/UeORThoYq+JMjZDgFaGYkzxXlNHmiL rQns8SwR/6spj5k7JdgbM9rdPPxiK2o= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-9Zllh4QWNyyp3evkjRF48Q-1; Wed, 23 Oct 2019 17:09:12 -0400 Received: by mail-lf1-f72.google.com with SMTP id l2so2297404lfk.21 for ; Wed, 23 Oct 2019 14:09:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=j8uth/YyCcw2cd/AKaSr6zH2GVsN12xt/bp7qE7X9Ng=; b=s0hm/JSLa9P4N00jRWlap/Vvj6fxcZpr7NiUyn/rjxhZQsozkj05EEhQB1tWBs/VWL Lz8fsAHwSABI5oE35+raJplpPGKhlIloxq+Kxv/9e2LdroAY/2yCsjrloYIIXBZxbjuq cn2Iz5QFdj6P/6iGYccS64dU+0TtgLcqisS+6gY4i2ioryX0jHic7h0lfiwgOYH/mr5a VB4Y79yYzTxUXMhmkElqCmDZS93lkzrgrOXdaRFp+omZ59HlB4GL/AX3BLRVZ6hzwqPD ddlzABRSJAWJhyEObBGvq8ELtc/B0w/QpzD763OYeEh1hHv0xWBiP/1FSMI5uGmuL192 TU1g== X-Gm-Message-State: APjAAAVZQpQM7lmK4sAI0vo/XDlDoJ9avMEW6OpY6RB+o6USoHGDzDNr +CFMbtbq7icDWnDbQZr5JmRogQA2fFVfPcaF7FMuSyKDuWX4MHNOd2pIECfyeI2tOpSBjhJ8BXf X2oBC6EfCdJLgXnkrpA1La1YVqOF2+c1w05A= X-Received: by 2002:a2e:9e4c:: with SMTP id g12mr24328840ljk.103.1571864950205; Wed, 23 Oct 2019 14:09:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYFFtiQHnJ5LqHgsHhFH7IcaoyXeT9h2Tuo3q9/5F1AX2go+DSXHCEgirMEaZeL4pFglNNZQ== X-Received: by 2002:a2e:9e4c:: with SMTP id g12mr24328834ljk.103.1571864950024; Wed, 23 Oct 2019 14:09:10 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id z1sm9491454ljh.88.2019.10.23.14.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 14:09:09 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 1DE0C1804B1; Wed, 23 Oct 2019 23:09:08 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes In-Reply-To: References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> <871rv5ovwr.fsf@toke.dk> <87tv7znact.fsf@toke.dk> <87lftbn60t.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 23 Oct 2019 23:09:08 +0200 Message-ID: <877e4vmaob.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: 9Zllh4QWNyyp3evkjRF48Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2019 21:09:15 -0000 Kan Yan writes: >> >> Aha! Turns out I was doing the sta lookup completely wrong in >> ieee80211_report_used_skb(); so anything frames that were dropped and >> went through there would not get its airtime subtracted correctly. Will >> send a v6 with a fix :) > > Awesome, thanks! That looks very promising. The symptom I see with > previous patch is the interface's pending airtime count looks fine, but t= he > station's airtime get wrong, either due to airtime is credited to the wro= ng > station or wrong AC. Right, if the interface count is fine that means it's not a missing call to the subtraction. So hopefully it will be fixed with v6 :) -Toke