From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DCE9D3B2A4 for ; Fri, 18 Oct 2019 10:30:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571409042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bakk7ZMdh+u0X+Hl2jLm9/YFhVpOg7xiWkA7OuAAt3c=; b=FqiIdoCZy+zbX9zypwpUInGzUtkkzeJ7hV1giQizdaAYVOJBsRGpZp5bMgWcyzy3REH4iK yMrJmhwgjj4R58X7eHdAVn8P5V6W2ztvCC2i5mZjI3iqhsW1WcSsACIFRUKwX7jRq0yrBE aOfZplDO3PypNDrnd3vHsc4Hujmg/DU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-9l5hGASrOeS6gDTooPYIbg-1; Fri, 18 Oct 2019 10:30:41 -0400 Received: by mail-lj1-f199.google.com with SMTP id b90so1116915ljf.11 for ; Fri, 18 Oct 2019 07:30:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=rKJhlEJJw/5ARrgpbdb2WsNHVUGoOLGpeEW6RcLOYbk=; b=gfRY4CwzCVoqyrD+Do7UzUcFF15THsDexlhmV1eEr5JQA5EB0avggjBGegkQfuC921 bQufex36lJg6SGVbJlTOx4Qm2X0mKt7KONbb0yLtMGUmILmsFFfER4PhhV0bWYS3vAEH fxA0t31XCAJXfB4FaoXOKKSD5X+nfSt5wLXR0eL/o8k/kJ9b9LljbnE5+1Kt/dpLEtBD d5AhQoknNzR1J4VUzPztZ/f422v/0hbkaDNWzRiyQcZSFFJ3uXhvhMWPJsp7IkbGS9Rt 6Nqg45h3TAAftY7lysygHYWFGXHnn5LLBQi3FHFP57CeDWaUdk9kwHiGhfmGpDc9RYFA 9ThA== X-Gm-Message-State: APjAAAUAD8OlQZI1595+ZpiGbXFc+sGHYS8mtccR7ymsr+pdcPFlWXKf 0fIOeql6qmIV3Qdwq91S3LuDPXSbHPu/81x+vKrQQXuAxDHp71L/tQfSTkfwQtlA8pKyHXVltPy PspiAgw4r6keoYMtyDY98gfr4lvXqiP07ofk= X-Received: by 2002:ac2:41d4:: with SMTP id d20mr594285lfi.24.1571409039651; Fri, 18 Oct 2019 07:30:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzILyzAuOEIj5ig6vIuTDFP316XFk3tSJVizLbq8TAYqZMR4SvKuZP0W2lfpHxx007dUHDYlg== X-Received: by 2002:ac2:41d4:: with SMTP id d20mr594270lfi.24.1571409039487; Fri, 18 Oct 2019 07:30:39 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id b20sm2413663ljo.106.2019.10.18.07.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 07:30:38 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3A6D81804B6; Fri, 18 Oct 2019 16:30:38 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes In-Reply-To: <78035e38264feac9d15a761b009c89b9738b4de1.camel@sipsolutions.net> References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115993866.2500430.13989567853855880476.stgit@toke.dk> <87sgnqe4wg.fsf@toke.dk> <10b885b3238cede2d99c6134bebcc0c8ba6f6b10.camel@sipsolutions.net> <87imomdvsj.fsf@toke.dk> <9fc60b546b54b40357264d67536733251cf39ebe.camel@sipsolutions.net> <87d0eudufu.fsf@toke.dk> <78035e38264feac9d15a761b009c89b9738b4de1.camel@sipsolutions.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 18 Oct 2019 16:30:38 +0200 Message-ID: <877e52dt2p.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: 9l5hGASrOeS6gDTooPYIbg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 14:30:42 -0000 Johannes Berg writes: > On Fri, 2019-10-18 at 16:01 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >>=20 >> > We can also play with the units of the airtime, e.g. making that a >> > multiple of 2 or 4 us? Seems unlikely to matter much? >>=20 >> Sure, that's a good point! Increments of 4us means we can fit 4ms is 10 >> bits, leaving plenty of space for ACK IDs (hopefully). > > If you do need more bits (e.g. to be on the safe side and have space for > 8ms) you could also steal bits out of 'band' (we only need 3 I think) > and 'hw_queue' (not sure what the limit really is, but there aren't many > users, seems like only iwlwifi/dvm and hwsim care, and those certainly > don't need >32 queues). > > Of course if you leave more bits for later that's good too ;-) Yeah, let's leave that for later. After all, with the limits we currently have configured, if a single packet takes up 4096 us, that will trigger the per-station queue throttling in itself, so I think we'll be fine (famous last words). -Toke