[Make-wifi-fast] codel params in net-next

[Make-wifi-fast] codel params in net-next

[Dave Taht]

I remember that this bit in sta_info.c was hacky. But in testing today
I'd seen drops
where I'd expected ecn, and didn't know it turned it off!

I was also thinking this triggered a bit too often with multiple
stations, and perhaps sta->local->num_sta should be an ewma of the
most recently transmitted stations or some other value. Am I
misunderstanding what num_sta is?

static void sta_update_codel_params(struct sta_info *sta, u32 thr)
{
        if (!sta->sdata->local->ops->wake_tx_queue)
                return;

        if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {



-- 

Dave Täht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740

Re: [Make-wifi-fast] codel params in net-next

[Toke Høiland-Jørgensen]

Dave Taht <dave.taht@gmail.com> writes:

> I remember that this bit in sta_info.c was hacky.

Heh, a tiny bit, maybe? ;)

> But in testing today I'd seen drops where I'd expected ecn, and didn't
> know it turned it off!
>
> I was also thinking this triggered a bit too often with multiple
> stations, and perhaps sta->local->num_sta should be an ewma of the
> most recently transmitted stations or some other value. Am I
> misunderstanding what num_sta is?

No, I don't think you are. For the airtime policy stuff in hostapd I use
queue length as a proxy for activity (any station which was backlogged
within the last N msecs is considered active). This is all tracked from
userspace through polling, though, so there's no counter for this in the
kernel. Should be possible to add it, though...

-Toke