From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 587103CB35 for ; Thu, 8 Aug 2019 14:30:06 -0400 (EDT) Received: by mail-ed1-f66.google.com with SMTP id s49so57091013edb.1 for ; Thu, 08 Aug 2019 11:30:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=uzKRFgU4v4A1LRmKpcLgCXbIp3SGST6J2KddRCK7gmk=; b=jHEzBa8m4b6H53K9g490xYZqs2yJfcBHbd1JLmXSG+EI1WeWFPB9JbEg97fyFf1cIK zOhjn+ga6V7IyVrRb7CN6ftjIvUs0yU5t8jbfCrSsU1JEOAdAJOMKaAdVrNygPYOlUHL ubAa0NCgKjoczuE56d7l1nYO+D26rPwp1OgeGlmqOFrfk0Uc8RP3I7QHzVOUl7NzVK16 vw9M1hj89Ee4nj5aCdLYza8m8skYvAmTLCFQjDOE1UaPqvkiRnIklLcEmXGfOM0caA05 x4aRKvtXDR7fhy7BAMHdBHSkVeH/HGpI2R1LmRqaaqQ5J+1MxCxWeyTF5gJJBl+nec1x 9yVA== X-Gm-Message-State: APjAAAX4dkbK89P0qG7HvNAYp6bhIT9ki9Wqt81oLJiN3AlAu3okUKVq ZRr33Vr+Dv6Nj1OZtWq6M2QYOw== X-Google-Smtp-Source: APXvYqwb8Y/IFqYuLA/b8fxME7o4YQQ+fXk2yOPC36nemRS4Kh4r/pFIHFNqcx1Q9MCtAWMTUr/eYw== X-Received: by 2002:a17:906:d052:: with SMTP id bo18mr14351656ejb.311.1565289005472; Thu, 08 Aug 2019 11:30:05 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id e24sm12430417ejb.53.2019.08.08.11.30.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 11:30:04 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2B0281804B2; Thu, 8 Aug 2019 20:30:04 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Dave Taht , Make-Wifi-fast In-Reply-To: References: X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 08 Aug 2019 20:30:04 +0200 Message-ID: <877e7ntsr7.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] codel params in net-next X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 18:30:06 -0000 Dave Taht writes: > I remember that this bit in sta_info.c was hacky. Heh, a tiny bit, maybe? ;) > But in testing today I'd seen drops where I'd expected ecn, and didn't > know it turned it off! > > I was also thinking this triggered a bit too often with multiple > stations, and perhaps sta->local->num_sta should be an ewma of the > most recently transmitted stations or some other value. Am I > misunderstanding what num_sta is? No, I don't think you are. For the airtime policy stuff in hostapd I use queue length as a proxy for activity (any station which was backlogged within the last N msecs is considered active). This is all tracked from userspace through polling, though, so there's no counter for this in the kernel. Should be possible to add it, though... -Toke