From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 04D083B29D
 for <make-wifi-fast@lists.bufferbloat.net>;
 Tue, 14 Feb 2023 06:36:58 -0500 (EST)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1676374616; bh=5ww0YeNmCGZtHvOsw7oe5gLgokS3BYzocnItBhuEfvI=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=qWxu+bDrNz3w/wF2+cbqIRh6Ebv4KrCNzcacO8JVeiJpliRrd9x6oSAQ8rrF5URpW
 JRd6maumYWXQYsrsvQgeGvuWv4kZ8EAmIbu9m525gg8k/G5RMk+y+B7gK7EO8Q50XT
 jWLYP/Di6dsl4KyMUlNvPwo80E0bScWhpI29x9I2sL3fY1lBdkaxvWOzIDyapAsyWY
 S2/XP12w57Z85dVPWNP9CPXQGDRRuAxhgHKWXLTnaPbatThHsoEsSOX6IZtjBTGfa4
 Lusu1/Rb40thjRcd0K6WyDVcH7UK4BMcmx2CQZxq6haZi5Wybw84skGuTr8k1J3jO7
 93WyfU8r01+xA==
To: Dave Taht <dave.taht@gmail.com>, Make-Wifi-fast
 <make-wifi-fast@lists.bufferbloat.net>
Cc: "Xianjun Jiao (UGent-imec)" <Xianjun.Jiao@ugent.be>
In-Reply-To: <CAA93jw6d0fD7nTLud02ZG3-5AtkvEwRKU4rbL38Sf5Sx5Y-Jiw@mail.gmail.com>
References: <CAA93jw6d0fD7nTLud02ZG3-5AtkvEwRKU4rbL38Sf5Sx5Y-Jiw@mail.gmail.com>
Date: Tue, 14 Feb 2023 12:36:56 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87a61gv5pj.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Make-wifi-fast] I wish we had a tutorial as to how to get the
 make-wifi-fast APIs implemented.
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2023 11:36:59 -0000

Dave Taht via Make-wifi-fast <make-wifi-fast@lists.bufferbloat.net>
writes:

> and what to look for in results.
>
> It should be really easy to add it to this: https://github.com/open-sdr/openwifi
>
> Related to here:
>
> https://www.linkedin.com/feed/update/urn:li:activity:7030534265935142912/
>
> But I no longer remember what is required to enable it properly.

The iTXQ path is mandatory in mac80211 since commits:

c850e31f79f0 ("wifi: mac80211: add internal handler for wake_tx_queue")
a790cc3a4fad ("wifi: mac80211: add wake_tx_queue callback to drivers")
107395f9cf44 ("wifi: mac80211: Drop support for TX push path")

See that second commit for the minimum one-line change needed to drivers
to work with this mode (it's a one-line change). A driver can also
choose to implement its own custom wake_tx_queue handler, of course.

-Toke