From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 178223CB35 for ; Fri, 8 Nov 2019 05:56:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573210598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z632feK0xo57emf6fFS5gwdIUzpWePHRoWFGwMcdBdg=; b=ekRcv3h6ccz6f8OKAX0PS4OD3lRYRwE0LNQkQ+gex/dSgqHZnumvLeVRzjnKvsht6Fuexn sd8YEb468ZydkTz+LYIzTLFMLdaP84gAlRrp4M+UqYL22oxzK4VzFtbD4JWk5WcB7strX8 iK8cEEfSGocrzkAgjpdj9yVkMeJFPBw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-x5j35xraNl-ufkoiBS6Qkg-1; Fri, 08 Nov 2019 05:56:37 -0500 Received: by mail-lj1-f200.google.com with SMTP id e17so1166156ljj.12 for ; Fri, 08 Nov 2019 02:56:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=B9ScARlo/HyQ+QLgyEDozc6otjhcAwH0CJnAxZVp+qs=; b=St2A+Cj/iqnvuAUcP3Q1/3k9xrbkOdpBOmE5EBH/DZqkEG7jZfkcV/74KHP3tfWy9k hvnWBVzOPL5jae87cFVMhQFp3zBOmWOfpRDgsCIC9mUyPaDDGuZYvEe6YbMwlkmOG7l3 uA3UlfLHFrtCf+eM4TWyzURutQn9xIvXThd2VIHGa48WDjatAKEldMV3ORwjGoOXp9I8 AqLrIjCizHNQMryn1DkNp5nMvY6XWE+8kkdFilSqSiEwq24g5m8YneHYBGYDWeOx/aTX v9GChhQ6fgGngqm8zxtwu+6enHHdGR/5HOiYO2iwLTRCJun5W/xTv9O9JmLQD7yo6xxv 2bQw== X-Gm-Message-State: APjAAAXs+2w32tFvy7yEq4EfmnZOccWguBSepcvxCrLZOe+XPqhlaLbT nDWUFS2IeG2Dv9CS3TA0WUt8MkyKQ3hQ6dAn464CmTLWPFUDVsov6oXIGMMw18dwtFCOlWDgceW v3Ba97E8eilb3R6v6eT2EP9ebTC8UbG9yDJI= X-Received: by 2002:a2e:481:: with SMTP id a1mr6439836ljf.209.1573210595635; Fri, 08 Nov 2019 02:56:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwFcYZbOdtEDfT7QaSh8Ph/WLAe9hmZ00Pfr21Wfx5hUy6ZBT/I3FE48cO9bVUQkyeCpv48Hw== X-Received: by 2002:a2e:481:: with SMTP id a1mr6439821ljf.209.1573210595508; Fri, 08 Nov 2019 02:56:35 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id x23sm810347lfe.8.2019.11.08.02.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 02:56:34 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 39B381818B5; Fri, 8 Nov 2019 11:56:34 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Kan Yan , Rajkumar Manoharan , Kevin Hayes In-Reply-To: <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474287.150713.12867638269538730397.stgit@toke.dk> <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 08 Nov 2019 11:56:34 +0100 Message-ID: <87a796fxgd.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: x5j35xraNl-ufkoiBS6Qkg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 10:56:39 -0000 Johannes Berg writes: > On Wed, 2019-10-23 at 11:59 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >>=20 >> =20 >> +void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local= , >> +=09=09=09=09=09 struct sta_info *sta, u8 ac, >> +=09=09=09=09=09 u16 tx_airtime, bool tx_completed) >> +{ >> +=09spin_lock_bh(&local->active_txq_lock[ac]); >> +=09if (tx_completed) { >> +=09=09if (sta) { >> +=09=09=09if (WARN_ONCE(sta->airtime[ac].aql_tx_pending < tx_airtime, >> +=09=09=09=09 "TXQ pending airtime underflow: %u, %u", >> +=09=09=09=09 sta->airtime[ac].aql_tx_pending, tx_airtime)) > > Maybe add the STA/AC to the message? Can do. Any idea why we might be seeing underflows (as Kan reported)? -Toke