From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D48D23B2A4 for ; Fri, 18 Oct 2019 10:22:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571408540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CZJB5jgfqOkbA3pAcKVegphLG5lxMMLqppKUI+v+NT0=; b=Ut6d6stWZtv9aT3GKNZQ/SC9XlcF+TvnzCMXCYbLpILuSc72m8LS+Kx8S3jc3IsdA3dln2 V2mBl50QeH3LPb0iJgpdAmg7+dBi/l9fSKltVPmFkeiw5Wm6KdAP87SfVa04XQ6sCZDs4k DxpPVyWEF4QIvaYOatEXN7MovPF55LY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-nr8qs8RlOpOQNoBx8eYykA-1; Fri, 18 Oct 2019 10:22:17 -0400 Received: by mail-lf1-f72.google.com with SMTP id m3so1156279lfo.4 for ; Fri, 18 Oct 2019 07:22:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=WFSLNDo34e/hQ4mMaXqwSinumGcSHTA3VPI9PdShktc=; b=f/KHw3K3Q7n6kCReJllMonOMsy6B99IpFEctQrt4D2WituG3+pfo6Rz/MsRdj94cyN vsBBtcVnDHL+YRSxwOt9SS1Yr8glD5yNvC62Owe1YMztf08ItTVWxixDbO72u5Ww57s9 hHgEAo+oiSSUNMr9QLknddfqIgdh4T04nMoDaQxORleFeoVS9A82RdfBpBkGrMXrXICz Y5qqigv1iO+gDCPOWNgnS5xLdAa+mWk9bvH66U/vl8mLtKbWlm6xhGDxiXb5VjxNFIhz wwaeYvOZtNhZynr8rSS8ykdANRXrRLRJUn/6x7sCjcEXcBQajh+M48m+rkSYpvdsBfUb edLQ== X-Gm-Message-State: APjAAAXIn0h6v+8bh1Lal1BNr9AGifpequpcRdaLE4xZ2BxpImCFcNxg +4u7yKRzfGR+kMLJSNIa/LrS5tw9WdoXJFzupDrA0LNgExJ1QDWUsafHddXdv9fVPA6YuJJxnL3 solS27dLKC/2YTl695jTASf2tvNZBuUtDNVc= X-Received: by 2002:a19:22c4:: with SMTP id i187mr5926912lfi.152.1571408535629; Fri, 18 Oct 2019 07:22:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqkwQ+FzoYv6pBFiWwEhgsIA1mrDfY6EuiAaZf0ZL91B2Z9tof0t8W9lR0jkYi1be643oQ1Q== X-Received: by 2002:a19:22c4:: with SMTP id i187mr5926898lfi.152.1571408535451; Fri, 18 Oct 2019 07:22:15 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id g3sm2667601lja.61.2019.10.18.07.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 07:22:14 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0FF491804B6; Fri, 18 Oct 2019 16:22:14 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes In-Reply-To: References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115993866.2500430.13989567853855880476.stgit@toke.dk> <87sgnqe4wg.fsf@toke.dk> <10b885b3238cede2d99c6134bebcc0c8ba6f6b10.camel@sipsolutions.net> <87imomdvsj.fsf@toke.dk> <9fc60b546b54b40357264d67536733251cf39ebe.camel@sipsolutions.net> <87d0eudufu.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 18 Oct 2019 16:22:14 +0200 Message-ID: <87a79ydtgp.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: nr8qs8RlOpOQNoBx8eYykA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 14:22:21 -0000 Johannes Berg writes: > On Fri, 2019-10-18 at 16:01 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : > >> Right. Well in that case, let's try it. As long as we fail in a >> reasonable way, we can just see if we run into anything that breaks? I >> guess in this case that means rejecting requests from userspace if we >> run out of IDs rather than silently wrapping and returning wrong data :) > > We can't reject due to how this works, but if the idr_alloc() fails then > we'll just not give a status back to userspace later. OK, I guess someone will notice if that suddenly starts happening all the time ;) >> > > We could also split 5/11. That would support up to 32 ACK IDs, and w= e >> > > can just truncate the airtime at 2048 us, which is not a big deal I'= d >> > > say. >> >=20 >> > We can also play with the units of the airtime, e.g. making that a >> > multiple of 2 or 4 us? Seems unlikely to matter much? >>=20 >> Sure, that's a good point! Increments of 4us means we can fit 4ms is 10 >> bits, leaving plenty of space for ACK IDs (hopefully). >>=20 >> I'll rework the series to use that instead :) > > OK. > > There are two places that call idr_alloc() with a hardcoded limit of > 0x10000, you'll have to fix those to have the right limit according to > the bits you leave for the ACK id. Yup, found those. Will send a new version of the series in a bit. -Toke