From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Tim Shepard <shep@alum.mit.edu>,
"make-wifi-fast@lists.bufferbloat.net"
<make-wifi-fast@lists.bufferbloat.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"nbd@nbd.name" <nbd@nbd.name>
Subject: Re: [Make-wifi-fast] [v5] ath9k: Switch to using mac80211 intermediate software queues.
Date: Wed, 09 Nov 2016 20:07:18 -0000 [thread overview]
Message-ID: <87a8d8v2mo.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <87k2cd0waf.fsf@toke.dk> ("Toke =?utf-8?Q?H=C3=B8iland-J?= =?utf-8?Q?=C3=B8rgensen=22's?= message of "Wed, 09 Nov 2016 11:42:16 +0100")
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> Tim Shepard <shep@alum.mit.edu> writes:
>
>>> While at it, could you also add to the commit log some info how awesome this
>>> patch is from user's point of view and how it helps. For example, before and
>>> and after numbers and other results.
>>
>> That varies wildly, depending on many details of the scenario
>> (including the wireless capabilities of the clients connected to the
>> AP using this patch, and how far away those clients are). There's
>> really not enough room in a commit message to explain enough to make
>> any such claimed numbers reproducible.
>
> I disagree; it's quite straightforward to demonstrate a gain from this
> on an ath9k access point. And while of course the mac80211 queues is the
> reason for this, the commit that uses it (i.e. this one) can explain
> that and include some numbers.
Yeah, so with that you are basically answering "Why?" part in the commit
log so that others can also understand the motivation behind all this.
> I'll add that and resend :)
Thanks. And sorry for taking so long with this, I have been basically
travelling most of the last month. I should get back home on Friday and
things should get normal soon.
--
Kalle Valo
next prev parent reply other threads:[~2016-11-09 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1c4IsV-0003Rk-00@www.xplot.org>
2016-11-09 10:42 ` Toke Høiland-Jørgensen
2016-11-09 20:07 ` Valo, Kalle [this message]
2016-09-02 14:00 [Make-wifi-fast] [PATCH v5] " Toke Høiland-Jørgensen
2016-10-07 11:43 ` [Make-wifi-fast] [v5] " Kalle Valo
2016-11-09 2:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8d8v2mo.fsf@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=shep@alum.mit.edu \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox