Re: [Make-wifi-fast] [v5] ath9k: Switch to using mac80211 intermediate software queues.

Re: [Make-wifi-fast] [v5] ath9k: Switch to using mac80211 intermediate software queues.

[Toke Høiland-Jørgensen]

Tim Shepard <shep@alum.mit.edu> writes:

>> While at it, could you also add to the commit log some info how awesome this
>> patch is from user's point of view and how it helps. For example, before and
>> and after numbers and other results.
>
> That varies wildly, depending on many details of the scenario
> (including the wireless capabilities of the clients connected to the
> AP using this patch, and how far away those clients are). There's
> really not enough room in a commit message to explain enough to make
> any such claimed numbers reproducible.

I disagree; it's quite straightforward to demonstrate a gain from this
on an ath9k access point. And while of course the mac80211 queues is the
reason for this, the commit that uses it (i.e. this one) can explain
that and include some numbers. I'll add that and resend :)

-Toke

Re: [Make-wifi-fast] [v5] ath9k: Switch to using mac80211 intermediate software queues.

[Valo, Kalle]

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> Tim Shepard <shep@alum.mit.edu> writes:
>
>>> While at it, could you also add to the commit log some info how awesome this
>>> patch is from user's point of view and how it helps. For example, before and
>>> and after numbers and other results.
>>
>> That varies wildly, depending on many details of the scenario
>> (including the wireless capabilities of the clients connected to the
>> AP using this patch, and how far away those clients are). There's
>> really not enough room in a commit message to explain enough to make
>> any such claimed numbers reproducible.
>
> I disagree; it's quite straightforward to demonstrate a gain from this
> on an ath9k access point. And while of course the mac80211 queues is the
> reason for this, the commit that uses it (i.e. this one) can explain
> that and include some numbers.

Yeah, so with that you are basically answering "Why?" part in the commit
log so that others can also understand the motivation behind all this.

> I'll add that and resend :)

Thanks. And sorry for taking so long with this, I have been basically
travelling most of the last month. I should get back home on Friday and
things should get normal soon.

-- 
Kalle Valo

Re: [Make-wifi-fast] [v5] ath9k: Switch to using mac80211 intermediate software queues.

[Kalle Valo]

Toke Høiland-Jørgensen wrote:
> This switches ath9k over to using the mac80211 intermediate software
> queueing mechanism for data packets. It removes the queueing inside the
> driver, except for the retry queue, and instead pulls from mac80211 when
> a packet is needed. The retry queue is used to store a packet that was
> pulled but can't be sent immediately.
> 
> The old code path in ath_tx_start that would queue packets has been
> removed completely, as has the qlen limit tunables (since there's no
> longer a queue in the driver to limit).
> 
> Based on Tim's original patch set, but reworked quite thoroughly.
> 
> Cc: Tim Shepard <shep@alum.mit.edu>
> Cc: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

All dependencies have trickled down to ath.git but unfortunately doesn't apply
anymore, so please rebase. Hopefully the last time :)

While at it, could you also add to the commit log some info how awesome this
patch is from user's point of view and how it helps. For example, before and
and after numbers and other results.

error: patch failed: drivers/net/wireless/ath/ath9k/xmit.c:921
error: drivers/net/wireless/ath/ath9k/xmit.c: patch does not apply
stg import: Diff does not apply cleanly

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/9311037/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [Make-wifi-fast] [v5] ath9k: Switch to using mac80211 intermediate software queues.

[Kalle Valo]

Toke Høiland-Jørgensen wrote:
> This switches ath9k over to using the mac80211 intermediate software
> queueing mechanism for data packets. It removes the queueing inside the
> driver, except for the retry queue, and instead pulls from mac80211 when
> a packet is needed. The retry queue is used to store a packet that was
> pulled but can't be sent immediately.
> 
> The old code path in ath_tx_start that would queue packets has been
> removed completely, as has the qlen limit tunables (since there's no
> longer a queue in the driver to limit).
> 
> Based on Tim's original patch set, but reworked quite thoroughly.
> 
> Cc: Tim Shepard <shep@alum.mit.edu>
> Cc: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

Depends on:

bb42f2d13ffc mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue

Patch set to Awaiting Upstream.

-- 
https://patchwork.kernel.org/patch/9311037/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches