From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AF7723B29E for ; Mon, 10 Sep 2018 07:16:20 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1536578179; bh=dQye9q4i1HGjVf27y/Suq6019gbBderboHe1fyDnZ5Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qg1I1hK4toSLp+3Azmi0ufnQp7BqjJmD1eQr8bUq8ebK+kat8eW3z18QtS68xi230 xK/99RYy2b5hgX2mI3BEk4CMBKnvUSrt9yPgYUHN012HV8k5EgnRRtt0llc6N03tpZ auxnAc5N6eyjPTf98qOMuWUbE1SIBEPsXKuFOjjAD9rzl24CLLnD7KZYV0EfrqyAOt d7Ecy7pI7Q5ZgVRt6ZU42Ue/Q9SwPcxUDE/H1EkrKfRVM75TANhN56lCqv4aOTgg4d 2EzFBluON8daTErZrwIirTWbArVdiMb1t3XQWiolukVKwH6nrecyDvaftDuwSylvbi K2mBT34CfxzdQ== To: Johannes Berg , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net Cc: Rajkumar Manoharan , Felix Fietkau In-Reply-To: <1536565561.3224.10.camel@sipsolutions.net> References: <153635803319.14170.10011969968767927187.stgit@alrua-x1> <1536565561.3224.10.camel@sipsolutions.net> Date: Mon, 10 Sep 2018 13:16:19 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87bm95li0s.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH RFC v3 0/4] Move TXQ scheduling into mac80211 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 11:16:20 -0000 Johannes Berg writes: > On Sat, 2018-09-08 at 00:22 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> - I didn't get rid of the register_airtime() callback. As far as I can t= ell, >> only iwlwifi uses the tx_time field in the struct tx_info. Which means= that >> we *could* probably use it for this and just make the other drivers se= t it; >> but I'm not sure what effects that would have in relation to WMM-AC for >> those drivers, so I chickened out. Will have to try it out, I guess; b= ut it >> also depends on whether ath10k needs to be able to report airtime >> asynchronously anyway. So I'll hold off on that for a bit more. > > I don't think you need to be concerned, the reporting through this has > no immediate effect as the driver would also have to set the feature > flag (NL80211_FEATURE_SUPPORTS_WMM_ADMISSION) for userspace to be able > to use WMM admission TSPECs, and getting tx_tspec->admitted_time to be > non-zero in ieee80211_sta_tx_wmm_ac_notify(). Great! In that case I'll try moving the reporting go through the tx_info struct and check that it works for ath9k :) -Toke