From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AF4B03B25E for ; Mon, 5 Sep 2016 17:25:10 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 9C3764161D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1473110707; bh=2jlu6IjmWIL/YNKPSyd98JT9R/AFBArtqVLvavJJq8Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ITdW7dl2mi/wBZwv5sQigEFvVmdB+AkkRSg8rpSm+OdObOrzRUhyromR3LSKJnykQ HD8TEOj2JbwJt93AnlkW0JlX/DHpYDmcV8nSdLnIuFV9D2ecfoPJM5L6b0ligghNuy Pkk7pwwZ+WNjAQeys4O6fjZTnINQL2VzmC8GnemY= Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8EEDA7AB8; Mon, 5 Sep 2016 23:25:07 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Dave Taht Cc: Felix Fietkau , make-wifi-fast@lists.bufferbloat.net References: <20160902134104.29309-1-toke@toke.dk> <20160905113042.22271-1-toke@toke.dk> <87oa4249hf.fsf@toke.dk> <8760qab6ly.fsf@toke.dk> <87oa429iu3.fsf@toke.dk> Date: Mon, 05 Sep 2016 23:25:07 +0200 In-Reply-To: (Dave Taht's message of "Mon, 5 Sep 2016 14:02:41 -0700") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87d1ki9gzw.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [PATCH v7] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 21:25:10 -0000 Dave Taht writes: >> Ah, no, those are not panics, those are warnings being triggered by the >> fast_tx pointer going while the packet was queued. Now, the >> xmit_fast_finish() function doesn't actually use that for anything other >> than crypto key configuration, so it would probably be feasible to get >> rid of that check in the dequeue path. >> >> How many of those warnings do you see? > > I'm not crazy, I run the rrul test at the conclusion of the run. Which this was. > > I'll go run it on a fresh boot but... > > dmesg | grep 'cut here' > > [ 707.011531] ------------[ cut here ]------------ > [ 707.343296] ------------[ cut here ]------------ > [ 707.676275] ------------[ cut here ]------------ > [ 708.009204] ------------[ cut here ]------------ > [ 708.342138] ------------[ cut here ]------------ > [ 709.247082] ------------[ cut here ]------------ > [ 709.580053] ------------[ cut here ]------------ > [ 709.913023] ------------[ cut here ]------------ > [ 710.245975] ------------[ cut here ]------------ > > Also attached. > >> And what do you have to do to get >> traffic to flow again? > > Seems to come back after a while. Right. Put up a bunch of new images (the ones with version +3). Completely untested, but should get rid of the need for the fast_tx pointer. See if you can blow those up? :) -Toke