From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E0B563B2A0 for ; Wed, 17 Aug 2016 09:23:30 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 446F240D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1471440209; bh=RNoR6mNR6tfaxMDpjtrFePlGVKBJzxoGvsAP2QHjsA4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rRcVxk58eLojShRsWRIKHg4kOSo3B2edZZ4lEIPQsEz3GSBvi8xz4Bk2rLHVnh93j ur/co1cBNLweK9DEPGYgJ/sNDbLzfFGM/wf5c14NUndeAfcm2zeOW0rBDykzpasbAO 7bt9jJ2VNhJIrYaxk+fNadMBu7OTjzxbG1QHAF80= Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 78B1C5F9E; Wed, 17 Aug 2016 15:23:28 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, Felix Fietkau References: <20160817125800.19154-1-toke@toke.dk> <1471439315.5173.7.camel@sipsolutions.net> <87h9aj5ydx.fsf@toke.dk> <1471439894.5173.9.camel@sipsolutions.net> Date: Wed, 17 Aug 2016 15:23:28 +0200 In-Reply-To: <1471439894.5173.9.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 17 Aug 2016 15:18:14 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87d1l75y27.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH] mac80211: Move crypto IV generation to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 13:23:31 -0000 Johannes Berg writes: > On Wed, 2016-08-17 at 15:16 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Johannes Berg writes: >>=20 >> >=20 >> > >=20 >> > > @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf { >> > > =C2=A0 u8 iv_len; >> > > =C2=A0 u8 hw_key_idx; >> > > =C2=A0 u8 flags; >> > > + u8 pn_offs; >> > >=20 >> > This is completely wrong. >>=20 >> Well, the ieee80211_fast_tx struct is not available in >> ieee80211_tx_dequeue, and I need the offset there. I thought about >> sticking it into ieee80211_tx_info, but that is kinda full, and since >> the ieee80211_key_conf is already available there, carrying it there >> seems to work. > > For very limited testing, perhaps. But this isn't static across all > usages of the key, so this is still completely broken. OK, noted. >> What would be a better way to do this? >>=20 > > Some redesign/rearchitecture, probably. Or just do it all in the driver > like iwlmvm? Will look it over again. Should be possible to re-calculate the offset, I guess. -Toke