From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
Dave Taht <dave@taht.net>,
Battle of the Mesh Mailing List <battlemesh@ml.ninux.org>
Subject: Re: [Make-wifi-fast] [Battlemesh] Wifi Memory limits in small platforms
Date: Thu, 22 Aug 2019 21:37:39 +0200 [thread overview]
Message-ID: <87ef1dng8s.fsf@toke.dk> (raw)
In-Reply-To: <CAA93jw7kSn9gwZsqqgO9w031oz5PgpUw1nhQwt5Y1x9dQ63MoA@mail.gmail.com>
Dave Taht <dave.taht@gmail.com> writes:
> On Thu, Aug 22, 2019 at 11:23 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>>
>> Sebastian Gottschall <s.gottschall@newmedia-net.de> writes:
>>
>> > Am 22.08.2019 um 19:03 schrieb Dave Taht:
>> >> Sebastian Gottschall <s.gottschall@newmedia-net.de> writes:
>> >>
>> >>> Am 22.08.2019 um 15:15 schrieb Dave Taht:
>> >>>> It's very good to know how much folk have been struggling to keep
>> >>>> things from OOMing on 32MB platforms. I'd like to hope that the
>> >>>> unified memory management in cake (vs a collection of QoS qdiscs) and
>> >>>> the new fq_codel for wifi stuff (cutting it down to 1 alloc from four)
>> >>>> help, massively on this issue, but until today I was unaware of how
>> >>>> much the field may have been patching things out.
>> >>>>
>> >>>> The default 32MB memory limits in fq_codel comes from the stressing
>> >>>> about 10GigE networking from google. 4MB is limit in openwrt,
>> >>>> which is suitable for ~1Gbit, and is sort of there due to 802.11ac's
>> >>>> maximum (impossible to hit) of a txop that large.
>> >> I did kind of conflate "qos + fq_codel" vs wifi in this message. It
>> >> looks like yer staying with me.
>> >>
>> >>>> Something as small as 256K is essentially about 128 full size packets
>> >>>> (and often, acks from an ethernet device's rx ring eat 2k).
>> >>> what i miss in mac80211 is the following option "fq_codel = off"
>> >>> its essential and i will definitly work on a patch to deal with this
>> >>> way for low memory 802.11n platforms.
>> >> Well, it would be my hope that turning it off would A) not help that
>> >> much on memory or cpu and B) show such a dramatic reduction in
>> >> multi-station performance that you'd immediately turn it on again.
>> > isnt it better to have a working platform with less performance than a
>> > crashing platform with no performance?
>> > i mean i can user older mac80211 versions without that issue on a
>> > typical nanostation 2/5 which is often used just as CPE device
>>
>> So before the queueing patches to mac80211, the maximum packet queue
>> size for ath9k was 3MB in total, or 2.2MB if only a single AC was used
>> on the WiFi link (that's 128 packets in the driver + 1000 in the
>> pfifo_fast qdisc * 2074 bytes for the truesize of a full-size packet).
>> Whereas now the default is 4MB for a non-vht device. So it's not
>> actually that big of a difference, and as you've already discovered the
>> defaults can be changed.
>>
>> Would it be helpful to add support for setting the memory limit in
>> hostapd (to avoid having to patch the kernel default)?
>
> hmm. I guess exposing that via netlink, etc is a good idea. Me I just
> write the sys/kernel/debug/*/*/aqm files.
It already is, and you can set it through iw (as I pointed out
up-thread):
iw phy phy0 set txq memory_limit 2097152
But it's not supported in hostapd, so you have to do that manually as it
is now.
> btw:
>
> qos_map in my mind, for APs at this point, should default to the best
> effort queue only. Not sure how to set that in openwrt (I just patched
> it out of the kernel).
Think it's possible to set this in hostapd config; haven't tried it...
-Toke
next prev parent reply other threads:[~2019-08-22 19:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAA93jw4FDjYjxxStyzMu8eCz_6Ezcumg-iZaYeM3kBZ5da8MBQ@mail.gmail.com>
[not found] ` <fc64c772-d85c-deba-a0e4-4e590cfb76ee@newmedia-net.de>
[not found] ` <CAA93jw4Fm=uY08A3XHWh3d=OKNfraCeYHwFGtAdPH7a51vG6WA@mail.gmail.com>
[not found] ` <384866b4-4c91-cf2c-c267-ee4036e5fbf7@newmedia-net.de>
[not found] ` <87wof7sriw.fsf@toke.dk>
[not found] ` <6782ec15-30eb-63b0-f54f-376c5e6b840b@newmedia-net.de>
[not found] ` <87tvabsp99.fsf@toke.dk>
[not found] ` <74bccc2b-b805-255f-b6a7-83ade9af6765@newmedia-net.de>
[not found] ` <87r25fsn70.fsf@toke.dk>
[not found] ` <b52b087d-c21c-e190-1bc7-a06e5fe6305f@newmedia-net.de>
[not found] ` <54438C64-C613-438E-9CB9-6C6D0C5EAFA0@gmail.com>
[not found] ` <87sgpvflo4.fsf@taht.net>
[not found] ` <87wof6rf7t.fsf@toke.dk>
[not found] ` <7656FCDE-C590-4B0C-B191-B9FAC928A762@gmail.com>
[not found] ` <CAA93jw4sEE_oQsX66xLkE+YUv=wM7AchfpUspC0y_Bf2nLdVOQ@mail.gmail.com>
[not found] ` <5eb4c395-c718-2d28-65a7-9762cf8d5bea@newmedia-net.de>
[not found] ` <47AD5102-B66F-44A5-AADE-D167ECB94A61@gmx.de>
[not found] ` <1d772664-b6cc-a528-9725-96a431032875@newmedia-net.de>
[not found] ` <87v9uqea3x.fsf@taht.net>
[not found] ` <87tvaap57q.fsf@toke.dk>
[not found] ` <CAA93jw6f0kedxwoN-ER3W1QKeg0sMxVCy6YYk_gRbrVwhD42jQ@mail.gmail.com>
[not found] ` <5bbd2b81-9846-3a7a-130c-0f59e04fd2d1@newmedia-net.de>
[not found] ` <CAA93jw4=13D-+WHLYPiV4NPqeVJwrLJe=nkr+a9D9Cqvq49pEQ@mail.gmail.com>
2019-08-22 13:22 ` [Make-wifi-fast] Fwd: " Dave Taht
2019-08-22 14:59 ` [Make-wifi-fast] " Dave Taht
[not found] ` <dcb92eaf-928e-f909-981d-c2baf74fbc90@newmedia-net.de>
2019-08-22 17:03 ` Dave Taht
2019-08-22 17:37 ` Sebastian Gottschall
2019-08-22 18:23 ` Toke Høiland-Jørgensen
2019-08-22 18:56 ` Dave Taht
2019-08-22 19:37 ` Toke Høiland-Jørgensen [this message]
2019-08-22 20:10 ` [Make-wifi-fast] [Cake] [Battlemesh] " Sebastian Moeller
2019-08-22 20:30 ` [Make-wifi-fast] " Sebastian Gottschall
2019-08-22 23:39 ` Dave Taht
2019-08-23 6:25 ` Sebastian Gottschall
2019-08-23 6:48 ` [Make-wifi-fast] [Cake] " Sebastian Moeller
2019-08-22 20:32 ` [Make-wifi-fast] fq_codel_fast crash/lockup Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef1dng8s.fsf@toke.dk \
--to=toke@redhat.com \
--cc=battlemesh@ml.ninux.org \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=dave@taht.net \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=s.gottschall@newmedia-net.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox