From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CE4A63B29E for ; Mon, 10 Sep 2018 07:15:17 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1536578116; bh=2Dw905sJpB+ZWgxTuPDzXBJcE4PVE7Wub+p4q1jyIEI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cCV2PCES3l8pymVsOTmw5v2B7WpMSud7uxgqg0lC/MJ0t4d9oEBSTbNWnDjNH6tAf sfNZKuHq1uIsv920N5cdVFCm1ysGMPkMjgzzMZklDhV6xoWJHju9bUebJb6MwJegNX +QajMbavxa7ptLsF7UdtIiEX3QSta9Czzx0rSRu1ujBkq9F9f4mH+/PIHe4/LBmpJ7 yk8KGFKDQxaA8TrN2+3g7+Dyd6PEz6kw5B0U9DzZHFQFTbJjmio+YfWh2WgqW2/ha9 Yb+uv5YkL79yo6sDsiVZ9ppo3c5lBifVwBEYkM9yhuWWJsBnM1XV93Ml/iPXcx9UsC Q1akAcn8Aj5zg== To: Johannes Berg , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net Cc: Rajkumar Manoharan , Felix Fietkau In-Reply-To: <1536567800.3224.39.camel@sipsolutions.net> References: <153635803319.14170.10011969968767927187.stgit@alrua-x1> <153635897088.14170.10601367738164730253.stgit@alrua-x1> <1536567800.3224.39.camel@sipsolutions.net> Date: Mon, 10 Sep 2018 13:15:16 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87efe1li2j.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH RFC v3 3/4] cfg80211: Add airtime statistics and settings X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 11:15:18 -0000 Johannes Berg writes: > On Sat, 2018-09-08 at 00:22 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> This adds airtime statistics to the cfg80211 station dump, and also adds= a new >> parameter to set the airtime weight of each station. The latter allows u= serspace >> to implement policies for different stations by varying their weights. > > Maybe some documentation on the weights - both for other implementers as > well as users - would be useful. > >> + * @NL80211_STA_INFO_AIRTIME_WEIGHT: current airtime weight for station >> + * (u16, usec) > > how could the weight be in usec? copy/paste issue? Well, technically it is a usec value (the amount of airtime added to the deficit each round); but I agree that it shouldn't be documented as such if we want freedom to change the mechanism later... -Toke