From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id C54AA3B2A4
 for <make-wifi-fast@lists.bufferbloat.net>;
 Thu,  9 Nov 2017 21:34:02 -0500 (EST)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1510281239; bh=QTtV12DIqUHDxWsYfa/Zkg337tMnaOBBzmskI9bE3Sw=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=zL8JooMQIcqGTUY0bpqAByJuHS7tfegFMeyflAaPYhU5tmwGAX7fP3Ue6n59gfAHF
 EPsnlaoOafs9X78JlXGp/j1JVHzXmsnLmEc4hTk8sLwJWWd0qsVjMVkjJN4eIWITok
 WyKx+8sCuPIURYnpAVn3qPmJYrI9Pj51VR2276DDO5+4+J1Fg31Y1fKxi+YSyPGJRH
 5UdyZRDiTubgtIIVZKjjsyiL20812/2s/oZw/eg9q6PPNdoSPgrSjSm2dkQkoxjS3i
 o+nh6KPJ5i76k67YEMBdijHGkHzkcMmwgmhAgQ+0ML21qMyLHo3TKZxhF56rekzMOk
 SAoRb74RbqQyA==
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
 Dave Taht <dave.taht@gmail.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: "make-wifi-fast\@lists.bufferbloat.net"
 <make-wifi-fast@lists.bufferbloat.net>,
 "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
 "ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>
In-Reply-To: <a7b75767d01b46ef818f86dbd0c657a8@NALASEXR01H.na.qualcomm.com>
References: <20171109071945.11033-1-toke@toke.dk>
 <6112ae948ba2409da27709d01da567eb@NALASEXR01H.na.qualcomm.com>
 <87k1yzq9i8.fsf@toke.dk>
 <CAA93jw6yw5=ALMdRaRrGU9uySmov9HwM-mr2npRbzsSxHgSAGw@mail.gmail.com>
 <a7b75767d01b46ef818f86dbd0c657a8@NALASEXR01H.na.qualcomm.com>
Date: Fri, 10 Nov 2017 11:33:53 +0900
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87h8u2rhf2.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Make-wifi-fast] [PATCH] ath10k: Re-enable TXQs for all devices
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Fri, 10 Nov 2017 02:34:03 -0000

Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:

> Agree.. Even I am not fan of that patch in ath10k. IIRC Michal pushed
> this change as temp one and planned to revert it once it is fixed in
> stack or in driver.
>
> I thought Eric change in fq_codel is meant only for fatty udp flows.
> Forgive my ignorance.

It is, mostly. There's a separate possible issue with TCP performance
that we're looking into, but that is unrelated to TXQs.

-Toke