From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 33F823B2A0 for ; Wed, 17 Aug 2016 09:16:29 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 4480A40D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1471439787; bh=BJ5nvJdBtmGmsuxVAHaZc2Q+TelCYL3gIjF8y01guPA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Dqn90GucJ05cT1AWZZmGstOCUiQQ/ZiJO3R0lev1nRM1s0JQdXIEairJOLFLo+c7+ 2ZGQeLdygnBGhk76bZhB8VuMbo0Rh6LV3UdNtP+G7Qt+f9ZLaRpNUX5VQorVQQHkKe 4hXvQwAys4HBwci1MOCrpWvKKtj+KpLfVzc+QQws= Sender: toke@toke.dk Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 39B925F9B; Wed, 17 Aug 2016 15:16:26 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, Felix Fietkau References: <20160817125800.19154-1-toke@toke.dk> <1471439315.5173.7.camel@sipsolutions.net> Date: Wed, 17 Aug 2016 15:16:26 +0200 In-Reply-To: <1471439315.5173.7.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 17 Aug 2016 15:08:35 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87h9aj5ydx.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH] mac80211: Move crypto IV generation to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 13:16:29 -0000 Johannes Berg writes: >> @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf { >> =C2=A0 u8 iv_len; >> =C2=A0 u8 hw_key_idx; >> =C2=A0 u8 flags; >> + u8 pn_offs; >>=20 > This is completely wrong. Well, the ieee80211_fast_tx struct is not available in ieee80211_tx_dequeue, and I need the offset there. I thought about sticking it into ieee80211_tx_info, but that is kinda full, and since the ieee80211_key_conf is already available there, carrying it there seems to work. What would be a better way to do this? -Toke