From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7C8F73B25D for ; Fri, 8 Jul 2016 12:38:30 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 997EA40472 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1467995908; bh=WkW/y3ixfg5059m85zxqaST2SwOP2g7eiv03zlIfJ2g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=q2CkeX6+GVo76InPM6LXSNEA4mXRGyHzYUUjNgjWOD506uA0xPufZryLzBMSDA3ZI 0zcSVjLlWAYc0Xp3pkmykyUqPCY0MWWOtN8WrtrNL8tPDmyL+QMFzyoAHWUNe26dTo 2mBDWGVP5++UX7+Ha/dBBco6LhsoZScyvhYRnKpI= Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C466163D67; Fri, 8 Jul 2016 18:38:27 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau Cc: Kalle Valo , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Tim Shepard References: <87wpkwktx9.fsf@toke.dk> <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> <87lh1cksao.fsf@toke.dk> Date: Fri, 08 Jul 2016 18:38:27 +0200 In-Reply-To: (Felix Fietkau's message of "Fri, 8 Jul 2016 18:31:11 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87h9c0kruk.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 16:38:30 -0000 Felix Fietkau writes: > On 2016-07-08 18:28, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Felix Fietkau writes: >>=20 >>> On 2016-07-08 17:53, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>> Kalle Valo writes: >>>>=20 >>>>> Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>> This switches ath9k over to using the mac80211 intermediate software >>>>>> queueing mechanism for data packets. It removes the queueing inside = the >>>>>> driver, except for the retry queue, and instead pulls from mac80211 = when >>>>>> a packet is needed. The retry queue is used to store a packet that w= as >>>>>> pulled but can't be sent immediately. >>>>>>=20 >>>>>> The old code path in ath_tx_start that would queue packets has been >>>>>> removed completely, as has the qlen limit tunables (since there's no >>>>>> longer a queue in the driver to limit). >>>>>>=20 >>>>>> Based on Tim's original patch set, but reworked quite thoroughly. >>>>>>=20 >>>>>> Cc: Tim Shepard >>>>>> Cc: Felix Fietkau >>>>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>>>> >>>>> Nice work. >>>>=20 >>>> Thanks :) >>>>=20 >>>>> Because this is such a significant change, and to maximise testing >>>>> time, I'm planning to queue this for 4.9 (so I would apply this to >>>>> ath-next in 3-4 weeks after the merge window closes). But anyone who >>>>> wants to test this can use master-pending branch from my ath.git tree >>>>> (uses wireless-testing as the baseline). Sounds good? >>>>=20 >>>> Sounds good to me. I'm planning on backporting this and Michael's >>>> mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE. >>>> Hopefully that will get it some more testing as well. >>> I've pushed a backport of this into my LEDE staging tree: >>> https://git.lede-project.org/?p=3Dlede/nbd/staging.git;a=3Dsummary >>=20 >> Awesome! What about the FQ-CoDel mac80211 patches themselves? I have a >> tree where I've separated out the needed patches and rebased them on >> mainline 4.4.9. Can I post that somewhere (or just email you the series) >> and get you to include those as well? Or do I just dump the patch files >> into the LEDE patches dir and send that as a patch to LEDE? (I see your >> patch also refreshed subsequent patches; is there a script to do that >> automatically?) > You don't need to do anything here. LEDE does not use mac80211 and > drivers from the kernel tree, it's built using backports. > It's currently using a backports snapshot that I built myself from > wireless-testing 2016-06-20, which already includes FQ-Codel. Ah, didn't know that. Cool; and thanks for taking care of the backporting :) -Toke