From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>, Kan Yan <kyan@google.com>
Cc: linux-wireless@vger.kernel.org,
make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name,
yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org,
rmanohar@codeaurora.org, kevinhayes@google.com
Subject: Re: [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76
Date: Fri, 22 Nov 2019 14:11:18 +0100 [thread overview]
Message-ID: <87imnc3vk9.fsf@toke.dk> (raw)
In-Reply-To: <dea9da1dd31900306c886c308c555691552290f5.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
>> Well, one calculates bitrates while the other calculates airtime? ;)
>
> :)
>
>> But yeah, I get what you mean. I think Felix went through quite some
>> pains to structure this code to avoid divisions in the fast path. I
>> guess that is the main blocker for cfg80211_calculate_bitrate() to be
>> used instead (assuming we do want to consolidate them eventually). Not
>> sure if that can be fixed easily though?
>
> We could also do it the other way around?
as in bitrate = 1/airtime? Dunno, maybe? How important is precision to
the bitrate calculations?
> Or maybe we should keep both and use them as a sanity check for each
> other :P
Hmm, yeah, it should be possible to write a selftest to iterate through
all rates and compare the output of each calculation, shouldn't it?
Where would be a good place to put that?
-Toke
next prev parent reply other threads:[~2019-11-22 13:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 6:06 [Make-wifi-fast] [PATCH v11 0/4] Add Airtime Queue Limits (AQL) to mac80211 Kan Yan
2019-11-19 6:06 ` [Make-wifi-fast] [PATCH v11 1/4] mac80211: Add new sta_info getter by sta/vif addrs Kan Yan
2019-11-19 6:06 ` [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 Kan Yan
2019-11-22 12:12 ` Johannes Berg
2019-11-22 12:56 ` Toke Høiland-Jørgensen
2019-11-22 13:00 ` Johannes Berg
2019-11-22 13:11 ` Toke Høiland-Jørgensen [this message]
2019-11-22 13:15 ` Johannes Berg
2019-11-22 14:41 ` Toke Høiland-Jørgensen
2019-11-22 12:27 ` Johannes Berg
2019-11-22 12:56 ` Toke Høiland-Jørgensen
2019-11-19 6:06 ` [Make-wifi-fast] [PATCH v11 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) Kan Yan
2019-11-19 6:06 ` [Make-wifi-fast] [PATCH v11 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue Kan Yan
2020-02-26 20:30 ` Felix Fietkau
2020-02-26 21:56 ` Toke Høiland-Jørgensen
2020-02-27 8:24 ` Kan Yan
2020-02-27 10:42 ` [Make-wifi-fast] " Felix Fietkau
2020-02-27 11:07 ` Toke Høiland-Jørgensen
2020-02-27 12:00 ` Felix Fietkau
2020-02-27 8:34 ` Felix Fietkau
2020-02-27 10:07 ` Toke Høiland-Jørgensen
2020-02-27 11:34 ` Felix Fietkau
2020-02-27 11:59 ` Toke Høiland-Jørgensen
2020-02-27 9:25 ` Justin Capella
2020-02-27 10:17 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imnc3vk9.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=kevinhayes@google.com \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=rmanohar@codeaurora.org \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox