From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Sebastian Moeller <moeller0@gmx.de>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Kan Yan <kyan@google.com>,
Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>
Subject: Re: [Make-wifi-fast] [PATCH v2 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue
Date: Sat, 19 Oct 2019 14:14:42 +0200 [thread overview]
Message-ID: <87imolc4p9.fsf@toke.dk> (raw)
In-Reply-To: <661B8FD5-510B-4DC5-A080-F04CA1C10C71@gmx.de>
Sebastian Moeller <moeller0@gmx.de> writes:
>> On Oct 18, 2019, at 16:15, Johannes Berg <johannes@sipsolutions.net> wrote:
>>
>> On Thu, 2019-10-17 at 18:11 -0700, Kan Yan wrote:
>>> I don't think it is hard to take care of extra header size for frames
>>> with VLAN tags
>>
>> VLAN tags are payload as far as wifi is concerned, so no need to take
>> that into account ...
>
> Ah, good to know; but just out of curiosity is any of the
> following 7 Byte Preamble + 1 Byte start of frame delimiter
> (SFD) + 12 Byte inter frame gap (IFG) actually packaged into
> ethernet frames inside 802.11 packets? I would have guessed that
> at least the IFG would be dropped as it does not really exist as
> "data"?
No, those are accounted in the airtime calculation in airtime.c (Felix'
code). E.g.,:
duration = 20 + 16; /* premable + SIFS */
-Toke
next prev parent reply other threads:[~2019-10-19 12:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 17:18 [Make-wifi-fast] [PATCH v2 0/4] Add Airtime Queue Limits (AQL) to mac80211 Toke Høiland-Jørgensen
2019-10-15 17:18 ` [Make-wifi-fast] [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est Toke Høiland-Jørgensen
2019-10-18 0:50 ` Kan Yan
2019-10-18 10:15 ` Toke Høiland-Jørgensen
2019-10-18 12:21 ` Johannes Berg
2019-10-18 13:31 ` Toke Høiland-Jørgensen
2019-10-18 13:48 ` Johannes Berg
2019-10-18 14:01 ` Toke Høiland-Jørgensen
2019-10-18 14:07 ` Johannes Berg
2019-10-18 14:22 ` Toke Høiland-Jørgensen
2019-10-18 14:14 ` Johannes Berg
2019-10-18 14:30 ` Toke Høiland-Jørgensen
2019-10-18 12:35 ` Johannes Berg
2019-10-15 17:18 ` [Make-wifi-fast] [PATCH v2 2/4] mac80211: Import airtime calculation code from mt76 Toke Høiland-Jørgensen
2019-10-15 17:19 ` [Make-wifi-fast] [PATCH v2 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) Toke Høiland-Jørgensen
2019-10-15 17:19 ` [Make-wifi-fast] [PATCH v2 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue Toke Høiland-Jørgensen
2019-10-17 0:33 ` Kan Yan
2019-10-17 9:44 ` Toke Høiland-Jørgensen
2019-10-17 9:57 ` Sebastian Moeller
2019-10-17 10:24 ` Toke Høiland-Jørgensen
2019-10-17 10:25 ` Sebastian Moeller
2019-10-18 1:11 ` Kan Yan
2019-10-18 14:15 ` Johannes Berg
2019-10-19 11:37 ` Sebastian Moeller
2019-10-19 12:14 ` Toke Høiland-Jørgensen [this message]
2019-10-19 14:01 ` Sebastian Moeller
2019-10-19 16:56 ` Toke Høiland-Jørgensen
2019-10-19 21:22 ` Sebastian Moeller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imolc4p9.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kyan@google.com \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=moeller0@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox