From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A33503B29E for ; Sat, 19 Oct 2019 08:14:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571487288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=248v8kzBP82Bdc+fsfiSHO7cRgv+4tu6qsUfDFiE0vU=; b=LnenFDgjVA23QIX8OSVAj6j2GQHW8N2YumaiBD01yoquH9sZQ1mAUrgGA5TjXb5qMqVTuU M7SWCm4qRbFkIKXP9u0u+p+250OXc1RuhXEZw4BsPr55FYYktDdQoN4Jv1Q2uBAJ851oHE 9XJ3QNZj/xkgcaysWAhcMjYvI4zxsps= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-5221VMxqODKy9VCmA8vUOw-1; Sat, 19 Oct 2019 08:14:46 -0400 Received: by mail-lf1-f69.google.com with SMTP id 23so1597512lft.15 for ; Sat, 19 Oct 2019 05:14:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+RJXpNWWyo1WAEJBF1FifIk2OkVw8tqm68Jz+bdSizg=; b=brAo8cT4G0zK8Gd5OUsd/SwZlSaMZ5OqJ/2XRXiWMxABrFtb5LpQbS6Ojdyth/B55Y 2Vd2zyn/BNqAgXixq4Vk71rNPUiHxtgTxIdWTezGDfkO0wJIFDvK+0iK8jC9JmA+W/38 qSN/2DVCSf5FKM/x2MS5YMHNoNxfM1UiXEGgOHBqgD58bMJhFVzQ0E3MYAf0AYQBq003 Xo6C7tnY1teDFbFQaMJDzlu2S9zm4DjHmGomzO2O+IeDFv8eBntK/55Yt0Duq4EJPCsd SMJu5Qi+v1VI61D+i4K5SuzD3vCoe/iTqdBCEWqwjUEodYXppEF1Ypfqf1wvmz+fmmuL oaVw== X-Gm-Message-State: APjAAAWb8srmbTI+IwO+vNUcPQMvvDAs7qK3nGxh9QEOyGmWfjsvYnGH X0wG78gwuXMSDqzo2wKJW6SOE+sRO+8YiBBiaE3JF213c6cVKim9l/ja0h4Fe+q5b7aIxm0mE92 CC+Idsuser4MCFssoXk5oSnicd5f6xUu57/s= X-Received: by 2002:a2e:8183:: with SMTP id e3mr9076765ljg.14.1571487285120; Sat, 19 Oct 2019 05:14:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKrD/HwxYXAaeIZ0QkkL7+1k/Kg6N6Y4KSvYRt7VsE6AEMq5eagTpcTaDBMyq0cuq3Ga54PQ== X-Received: by 2002:a2e:8183:: with SMTP id e3mr9076761ljg.14.1571487284975; Sat, 19 Oct 2019 05:14:44 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id r6sm4161538ljr.77.2019.10.19.05.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2019 05:14:43 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 699C11804C8; Sat, 19 Oct 2019 14:14:42 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Sebastian Moeller , Johannes Berg Cc: Kan Yan , Make-Wifi-fast In-Reply-To: <661B8FD5-510B-4DC5-A080-F04CA1C10C71@gmx.de> References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115994190.2500430.14955682016008497593.stgit@toke.dk> <87o8yfg0zo.fsf@toke.dk> <751EA059-654B-4E06-A3D6-C727FE1FCE98@gmx.de> <87lftjfz51.fsf@toke.dk> <18FC6F1D-084C-44BD-87E7-C9F394D6FCD1@gmx.de> <32a96b6ad48387876b7125adba147578564d297a.camel@sipsolutions.net> <661B8FD5-510B-4DC5-A080-F04CA1C10C71@gmx.de> X-Clacks-Overhead: GNU Terry Pratchett Date: Sat, 19 Oct 2019 14:14:42 +0200 Message-ID: <87imolc4p9.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: 5221VMxqODKy9VCmA8vUOw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v2 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Oct 2019 12:14:48 -0000 Sebastian Moeller writes: >> On Oct 18, 2019, at 16:15, Johannes Berg wro= te: >>=20 >> On Thu, 2019-10-17 at 18:11 -0700, Kan Yan wrote: >>> I don't think it is hard to take care of extra header size for frames >>> with VLAN tags >>=20 >> VLAN tags are payload as far as wifi is concerned, so no need to take >> that into account ... > > =09Ah, good to know; but just out of curiosity is any of the > =09following 7 Byte Preamble + 1 Byte start of frame delimiter > =09(SFD) + 12 Byte inter frame gap (IFG) actually packaged into > =09ethernet frames inside 802.11 packets? I would have guessed that > =09at least the IFG would be dropped as it does not really exist as > =09"data"? No, those are accounted in the airtime calculation in airtime.c (Felix' code). E.g.,: =09=09duration =3D 20 + 16; /* premable + SIFS */ -Toke