From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2a00:7660:6da:2001::664]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 70EC93B2A4 for ; Tue, 4 Dec 2018 09:55:50 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1543935348; bh=kybGmhGVR/NmcRX+YnMiYnF1I7IBWiY/UtiHCH/7tZs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XvaXP/vtwEio6vOfQ8m4UIEEyQP8CclKzKmAsEVVPzzoG+ZoO3g3QKLguM/dHyd2p rtSWwh5bRQrBFLBlQm/ZEPXMhk0GYd+xLlD1lNwEL8cAt04sZkPK8EqntetWNw72Lp jbxmnHVx65o9I2tu4NmbgMtLW2KmoZhwJVpNYMhN+MPSpkzN0jAxIHc6tAr5XZ82Id oyd3TvqUUyE31VnaxCrRMlnROgf5tJ0Y9RhFPlQQFIcNLxwx1aLkIvdUGBWAWLgw8x VLDI5LTSKUFym1Hpidks7Lgq+pwJdSVVQHCQ+EqMeSjIZR8f0jvBr78DKFEEhaqd6l njPqCyaUZFBLw== To: Felix Fietkau , Rajkumar Manoharan , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cc: make-wifi-fast@lists.bufferbloat.net In-Reply-To: References: <1542063113-22438-1-git-send-email-rmanohar@codeaurora.org> <1542063113-22438-4-git-send-email-rmanohar@codeaurora.org> Date: Tue, 04 Dec 2018 16:55:45 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87in09ibny.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 14:55:50 -0000 Felix Fietkau writes: >> diff --git a/net/mac80211/status.c b/net/mac80211/status.c >> index aa4afbf0abaf..a1f1256448f5 100644 >> --- a/net/mac80211/status.c >> +++ b/net/mac80211/status.c >> @@ -818,6 +818,12 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw, >> ieee80211_sta_tx_notify(sta->sdata, (void *) skb->data, >> acked, info->status.tx_time); >> >> + if (info->status.tx_time && >> + wiphy_ext_feature_isset(local->hw.wiphy, >> + NL80211_EXT_FEATURE_AIRTIME_FAIRNESS)) >> + ieee80211_sta_register_airtime(&sta->sta, tid, >> + info->status.tx_time, 0); >> + >> if (ieee80211_hw_check(&local->hw, REPORTS_TX_ACK_STATUS)) { >> if (info->flags & IEEE80211_TX_STAT_ACK) { >> if (sta->status_stats.lost_packets) > I think the same is needed in ieee80211_tx_status_ext. So finally circled back to this. In ieee80211_tx_status_ext() we don't have an skb, so we don't know which TID the packet was sent to; what airtime information would the driver actually provide in this case? Is it an aggregate of all ACs, or? -Toke