From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C4C5B3B2A4 for ; Thu, 9 Nov 2017 19:10:16 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1510272613; bh=wBRggJx3/LesgoLKYJRwEmwNK6WlwZ0tf+SQFJBDv+4=; h=From:To:Subject:In-Reply-To:References:Date:From; b=r1BfUatuos5JnEaAlZGh1d8NdWm0XwH3m8mr4HCXIAzrMUEGx+hNMXbcziAzsV9Bd emzbyT/RdhOeu4w5qmpbI10g2govYGK1elz5zlGIqrHB6p9Yf5ioxsxASfAZyCR0pK xaDZW9bFff32tnMe8N3AfSIW2jggHxhQwGsfiDDq5+NzWPr1tQhqXjtI867ASdxGqj 7hjZpf/kP5LiHR8nioGRtvRfhahhOJRPyXBz8oVzR5/23utzqwMqt97oe2KSHHp5jO dAYoQK3WueWQzRkLTeL8Yh2bopSXxHTAZHq4rQsMEZjQO5tHR8t1DmDgzBJHJ3QgTy EPES97WGlPhtg== To: Rajkumar Manoharan , "make-wifi-fast\@lists.bufferbloat.net" , "linux-wireless\@vger.kernel.org" In-Reply-To: <6112ae948ba2409da27709d01da567eb@NALASEXR01H.na.qualcomm.com> References: <20171109071945.11033-1-toke@toke.dk> <6112ae948ba2409da27709d01da567eb@NALASEXR01H.na.qualcomm.com> Date: Fri, 10 Nov 2017 09:10:07 +0900 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87k1yzq9i8.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH] ath10k: Re-enable TXQs for all devices X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 00:10:17 -0000 Rajkumar Manoharan writes: >> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the >> mac80211 TXQs for some devices because of a theoretical throughput >> regression. We have not seen this regression for a while now, so it shou= ld be >> safe to re-enable TXQs. >>=20 >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> --- >> This has been in LEDE trunk for a couple of months now with good results. >> > Toke, >=20=20 > Good to know that the performance drop is not seen with the chips that do= es not > have push-pull support. The issue was originally reported with ap152 + qc= a988x > by community [1]. Hope this combination is also considered in LEDE. Ah, was that the original bug report? Thank you, I have not been able to find that anywhere! The issue that seems to point to has been fixed a while ago; I'll send and updated patch with a better commit message (also forgot to cc the ath10k list, I see). -Toke