From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3B3023B2A0 for ; Wed, 9 Nov 2016 18:12:10 -0500 (EST) Received: from mail.toke.dk (localhost.localdomain [127.0.0.1]) by mail.toke.dk (Postfix) with ESMTPS id 9EAF610CE79; Thu, 10 Nov 2016 00:11:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1478733075; bh=43BdzMmVMzi2GrC3o6Z4yudmsOHrWdAueHXuJqrx6rw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eTr2p3PIFjBUQa0oCQ/Sb3jOO1xYpE9U2YlMGAKB+u7WAlUql+QXqR1eJRsZB10DY eIAGcSdangsQNex7MGUIh7teqHgtB1qkYHV14fQPjvFfuxe1g6Z3ovHi9gOXeI5Woy vaBqStYYyaKr4dU82Na87dqslT8DVpcsPTpoYQ7VEIAfajrYbgVgrpABEzkEc2nYNk 9k8G/GgYwMcDSaNq4yRVpn96fl5epHvKmq5FD6m8BOeDV/tcq983qSADKrH+r+VG85 3qhoeZolECZG6/EfRX+VJzrwOkoyyHzmFL1RC5VaFfKBmM9p3fNmiy9iksjk5zUzak Wgo0EPct/rA5A== Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E7408F55F; Thu, 10 Nov 2016 00:10:40 +0100 (CET) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Kalle Valo Cc: , , Tim Shepard , Felix Fietkau References: <20161109113149.5724-1-toke@toke.dk> <689eea51fa77432cbe4c70c6c2fe7b13@euamsexm01a.eu.qualcomm.com> Date: Thu, 10 Nov 2016 00:10:40 +0100 In-Reply-To: <689eea51fa77432cbe4c70c6c2fe7b13@euamsexm01a.eu.qualcomm.com> (Kalle Valo's message of "Wed, 9 Nov 2016 23:42:47 +0100") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87k2ccz1u7.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [v6] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 23:12:13 -0000 Kalle Valo writes: > Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> This switches ath9k over to using the mac80211 intermediate software >> queueing mechanism for data packets. It removes the queueing inside the >> driver, except for the retry queue, and instead pulls from mac80211 when >> a packet is needed. The retry queue is used to store a packet that was >> pulled but can't be sent immediately. >>=20 >> The old code path in ath_tx_start that would queue packets has been >> removed completely, as has the qlen limit tunables (since there's no >> longer a queue in the driver to limit). >>=20 >> The mac80211 intermediate software queues offer significant latency >> reductions, and this patch allows ath9k to realise them. The exact gains >> from this varies with the test scenario, but in an access point scenario >> we have seen latency reductions ranging from 1/3 to as much as an order >> of magnitude. We also achieve slightly better aggregation. >>=20 >> Median latency (ping) figures with this patch applied at the access poin= t, >> with two high-rate stations and one low-rate station (HT20 5Ghz), running >> a Flent rtt_fair_var_up test with one TCP flow and one ping flow going to >> each station: >>=20 >> Fast station Slow station >> Default pfifo_fast qdisc: 430.4 ms 638.7 ms >> fq_codel qdisc on iface: 35.5 ms 211.8 ms >> This patch set: 22.4 ms 38.2 ms >>=20 >> Median aggregation sizes over the same test: >>=20 >> Default pfifo_fast qdisc: 9.5 pkts 1.9 pkts >> fq_codel qdisc on iface: 11.2 pkts 1.9 pkts >> This patch set: 13.9 pkts 1.9 pkts >>=20 >> This patch is based on Tim's original patch set, but reworked quite >> thoroughly. >>=20 >> Cc: Tim Shepard >> Cc: Felix Fietkau >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > Perfect, just what I was hoping to see :) Unless something really > surprising comes up I should apply this within the next few days. Awesome, thanks! :) -Toke