From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D54003B2A4 for ; Tue, 1 Oct 2019 05:39:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569922795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mh6wre2rKFFqyiOsqUY6NZ90QmROWYjjTocjJiWZidA=; b=IudLceV4YZ7hwFZV8eeVY8ez+tNiG/w04u3b4U23X5R+nGeB7qfWJvsc+gwnlhtAL3suqN nP5S/lSFSHu7CLXGPflA55E7idY3KKDpa//DSTSxBKN6vQv7NmsMU2FxB+2JoNcr0AWSgo 93btZMRnTZct1eGzCy977sPUB5kzfNE= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-iSoP3WV1OTKflNni1qHksQ-1; Tue, 01 Oct 2019 05:39:51 -0400 Received: by mail-lf1-f72.google.com with SMTP id z24so2661384lfb.15 for ; Tue, 01 Oct 2019 02:39:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=0AV/qi7FN67vmYSpoNF3PK6oGKufZjhJSMJcgKxRuIA=; b=LSdmdIKFYvLZ79L2dQCMY3dPG8WCqDH1NB1BBodafLfCcv2pbtLFZOX85qH/p4/vDC aqoGVtdh8198T1/6P6So3jDFIIqg/mbI5E+LT/EtMcW/W+G0HZzcyZBQl9fhaqI+HyTu AHw7ye2YEqw4K5d3k1HpE26o3M6NJ5alFnZKT+Oq3qCjGHebgyKMVe+vAyie7JUB7A4k MGhSx8JEsYqvn/mIVmI3iZ1wdRoU2CXAR+kb6RZ6oEAu2U3cNExrPOwlKJyqM/GJ6l+J L0QpFAfj4tHR/YZ4ObbQXdWcmwkxfipjxKTM9hZuIgVEZKfcCNd8zuYR3ud8o650OrXF pOQw== X-Gm-Message-State: APjAAAV0XA4PY4woPatRv1+VbLSzmqquBeqhDcIPLVck1AqDffmdOiOg /ZsJ7p/9JzTYOvvNhQSRBm0YCQZtZoOLAQnCGYsnV5vzVEqYMrPsJuR2y/bCpj8aRyLw6td5I/t zevA6LNWnERlWW6th9nGOm2hx0RfSojqeVqY= X-Received: by 2002:a2e:6c08:: with SMTP id h8mr15479810ljc.28.1569922790273; Tue, 01 Oct 2019 02:39:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwGMSw164aG5ltB2LcIDkpApPaI01p7En8Y8A9n9bACvqs0ay9eDmIcxo4GknUnVI3zsrCrqw== X-Received: by 2002:a2e:6c08:: with SMTP id h8mr15479799ljc.28.1569922790142; Tue, 01 Oct 2019 02:39:50 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id h2sm3859139ljb.11.2019.10.01.02.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 02:39:49 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id AD83418063D; Tue, 1 Oct 2019 11:39:48 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, John Crispin , Lorenzo Bianconi , Felix Fietkau In-Reply-To: References: <156889576422.191202.5906619710809654631.stgit@alrua-x1> <156889576534.191202.17686228416284995279.stgit@alrua-x1> <87v9t8vnn5.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 01 Oct 2019 11:39:48 +0200 Message-ID: <87lfu4vm6z.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: iSoP3WV1OTKflNni1qHksQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH RFC/RFT 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2019 09:39:55 -0000 Johannes Berg writes: > On Tue, 2019-10-01 at 11:08 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >>=20 >> Awesome! Any idea for how to make it work on big-endian systems? I got a >> splat from the kbuild robot that triggered the BUILD_BUG_ON when >> building for m68k. I assume it's the union with codel_time_t that ends >> up being aligned wrong... > > Hmm. Pad out the u16 part of the union by putting it into a struct, or > perhaps it's enough to make the union __packed? Yeah, another level of structs would probably work, but wanted to avoid another level of indentation. Although I guess even that would not make this the most-indented part of ieee80211_tx_info ;) I guess I'll look into the __packed thing, and go with another struct otherwise... -Toke