From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Felix Fietkau <nbd@nbd.name>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless@vger.kernel.org,
make-wifi-fast@lists.bufferbloat.net,
ath9k-devel@lists.ath9k.org, Tim Shepard <shep@alum.mit.edu>
Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues.
Date: Fri, 08 Jul 2016 18:28:47 +0200 [thread overview]
Message-ID: <87lh1cksao.fsf@toke.dk> (raw)
In-Reply-To: <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> (Felix Fietkau's message of "Fri, 8 Jul 2016 18:10:11 +0200")
Felix Fietkau <nbd@nbd.name> writes:
> On 2016-07-08 17:53, Toke Høiland-Jørgensen wrote:
>> Kalle Valo <kvalo@qca.qualcomm.com> writes:
>>
>>> Toke Høiland-Jørgensen wrote:
>>>> This switches ath9k over to using the mac80211 intermediate software
>>>> queueing mechanism for data packets. It removes the queueing inside the
>>>> driver, except for the retry queue, and instead pulls from mac80211 when
>>>> a packet is needed. The retry queue is used to store a packet that was
>>>> pulled but can't be sent immediately.
>>>>
>>>> The old code path in ath_tx_start that would queue packets has been
>>>> removed completely, as has the qlen limit tunables (since there's no
>>>> longer a queue in the driver to limit).
>>>>
>>>> Based on Tim's original patch set, but reworked quite thoroughly.
>>>>
>>>> Cc: Tim Shepard <shep@alum.mit.edu>
>>>> Cc: Felix Fietkau <nbd@nbd.name>
>>>> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
>>>
>>> Nice work.
>>
>> Thanks :)
>>
>>> Because this is such a significant change, and to maximise testing
>>> time, I'm planning to queue this for 4.9 (so I would apply this to
>>> ath-next in 3-4 weeks after the merge window closes). But anyone who
>>> wants to test this can use master-pending branch from my ath.git tree
>>> (uses wireless-testing as the baseline). Sounds good?
>>
>> Sounds good to me. I'm planning on backporting this and Michael's
>> mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE.
>> Hopefully that will get it some more testing as well.
> I've pushed a backport of this into my LEDE staging tree:
> https://git.lede-project.org/?p=lede/nbd/staging.git;a=summary
Awesome! What about the FQ-CoDel mac80211 patches themselves? I have a
tree where I've separated out the needed patches and rebased them on
mainline 4.4.9. Can I post that somewhere (or just email you the series)
and get you to include those as well? Or do I just dump the patch files
into the LEDE patches dir and send that as a patch to LEDE? (I see your
patch also refreshed subsequent patches; is there a script to do that
automatically?)
> I don't have time for testing it myself at the moment, but I'll try to
> get some people to do so.
Awesome :)
-Toke
next prev parent reply other threads:[~2016-07-08 16:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160617090929.31606-1-toke@toke.dk>
[not found] ` <20160617090929.31606-2-toke@toke.dk>
2016-06-17 13:28 ` [Make-wifi-fast] [PATCH 1/2] ath9k: use " Felix Fietkau
2016-06-17 13:43 ` Toke Høiland-Jørgensen
2016-06-17 13:48 ` Felix Fietkau
2016-06-17 16:33 ` Felix Fietkau
2016-06-17 14:10 ` [Make-wifi-fast] [ath9k-devel] " Dave Taht
2016-06-18 19:05 ` [Make-wifi-fast] [PATCH] ath9k: Switch to using " Toke Høiland-Jørgensen
2016-07-06 16:16 ` [Make-wifi-fast] [PATCH v2] " Toke Høiland-Jørgensen
2016-07-06 17:58 ` Sebastian Gottschall
2016-07-06 18:13 ` Felix Fietkau
2016-07-06 18:52 ` Toke Høiland-Jørgensen
2016-07-06 19:00 ` Felix Fietkau
2016-07-06 19:08 ` Toke Høiland-Jørgensen
2016-07-06 19:34 ` [Make-wifi-fast] [PATCH v3] " Toke Høiland-Jørgensen
2016-07-08 14:27 ` [Make-wifi-fast] [v3] " Kalle Valo
2016-07-08 15:53 ` Toke Høiland-Jørgensen
2016-07-08 16:10 ` Felix Fietkau
2016-07-08 16:28 ` Toke Høiland-Jørgensen [this message]
2016-07-08 16:31 ` Felix Fietkau
2016-07-08 16:38 ` Toke Høiland-Jørgensen
2016-07-08 18:24 ` Sebastian Gottschall
2016-07-09 12:00 ` Toke Høiland-Jørgensen
2016-08-05 16:03 ` [Make-wifi-fast] [PATCH v4] " Toke Høiland-Jørgensen
2016-08-22 15:44 ` Kalle Valo
2016-08-22 16:16 ` Toke Høiland-Jørgensen
2016-08-22 17:02 ` Kalle Valo
2016-08-22 17:13 ` Toke Høiland-Jørgensen
2016-08-23 6:59 ` Kalle Valo
2016-08-23 8:52 ` Arend van Spriel
2016-10-05 14:02 ` Toke Høiland-Jørgensen
2016-10-05 15:50 ` Kalle Valo
2016-10-05 16:55 ` Toke Høiland-Jørgensen
2016-10-05 17:54 ` Kalle Valo
2016-10-05 19:56 ` Toke Høiland-Jørgensen
2016-09-02 14:00 ` [Make-wifi-fast] [PATCH v5] " Toke Høiland-Jørgensen
2016-09-03 10:16 ` Felix Fietkau
2016-10-07 11:43 ` [Make-wifi-fast] [v5] " Kalle Valo
2016-11-09 2:22 ` Kalle Valo
2016-11-09 11:31 ` [Make-wifi-fast] [PATCH v6] " Toke Høiland-Jørgensen
2016-11-09 22:42 ` [Make-wifi-fast] [v6] " Kalle Valo
2016-11-09 23:10 ` Toke Høiland-Jørgensen
2016-11-15 15:00 ` Kalle Valo
2016-11-24 13:54 ` [Make-wifi-fast] [PATCH v2] ath9k: Introduce airtime fairness scheduling between stations Toke Høiland-Jørgensen
2016-11-28 10:12 ` [Make-wifi-fast] [PATCH v3] " Toke Høiland-Jørgensen
2016-12-15 8:43 ` [Make-wifi-fast] [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh1cksao.fsf@toke.dk \
--to=toke@toke.dk \
--cc=ath9k-devel@lists.ath9k.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=shep@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox