From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2BDE83B25D for ; Fri, 8 Jul 2016 12:28:51 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 1AB4440472 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1467995328; bh=PCCsEVEZT7VdhFhjfjgNh2klnoownrtWOCctbW5OC58=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PX80j1o6uzgd3yfEdCzw7QcX+OKma9VIzvNRCzEAg9eN8NU7OuEfnbTKtkHOd9I2G LZg0lVI3sKV7GSVkl/OFHW7vUy38IUzdwlJQji3J1GnyZGHB5SJVHkKm6ZIzWdp9mC aokBnx+/wxR23g4jtLO0t0jNwRMoWLfkyr3xqjIA= Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2FA0263D59; Fri, 8 Jul 2016 18:28:47 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau Cc: Kalle Valo , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Tim Shepard References: <87wpkwktx9.fsf@toke.dk> <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> Date: Fri, 08 Jul 2016 18:28:47 +0200 In-Reply-To: <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> (Felix Fietkau's message of "Fri, 8 Jul 2016 18:10:11 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87lh1cksao.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 16:28:51 -0000 Felix Fietkau writes: > On 2016-07-08 17:53, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Kalle Valo writes: >>=20 >>> Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>> This switches ath9k over to using the mac80211 intermediate software >>>> queueing mechanism for data packets. It removes the queueing inside the >>>> driver, except for the retry queue, and instead pulls from mac80211 wh= en >>>> a packet is needed. The retry queue is used to store a packet that was >>>> pulled but can't be sent immediately. >>>>=20 >>>> The old code path in ath_tx_start that would queue packets has been >>>> removed completely, as has the qlen limit tunables (since there's no >>>> longer a queue in the driver to limit). >>>>=20 >>>> Based on Tim's original patch set, but reworked quite thoroughly. >>>>=20 >>>> Cc: Tim Shepard >>>> Cc: Felix Fietkau >>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>> >>> Nice work. >>=20 >> Thanks :) >>=20 >>> Because this is such a significant change, and to maximise testing >>> time, I'm planning to queue this for 4.9 (so I would apply this to >>> ath-next in 3-4 weeks after the merge window closes). But anyone who >>> wants to test this can use master-pending branch from my ath.git tree >>> (uses wireless-testing as the baseline). Sounds good? >>=20 >> Sounds good to me. I'm planning on backporting this and Michael's >> mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE. >> Hopefully that will get it some more testing as well. > I've pushed a backport of this into my LEDE staging tree: > https://git.lede-project.org/?p=3Dlede/nbd/staging.git;a=3Dsummary Awesome! What about the FQ-CoDel mac80211 patches themselves? I have a tree where I've separated out the needed patches and rebased them on mainline 4.4.9. Can I post that somewhere (or just email you the series) and get you to include those as well? Or do I just dump the patch files into the LEDE patches dir and send that as a patch to LEDE? (I see your patch also refreshed subsequent patches; is there a script to do that automatically?) > I don't have time for testing it myself at the moment, but I'll try to > get some people to do so. Awesome :) -Toke