From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 731923CB35 for ; Tue, 12 Oct 2021 10:16:46 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1634048203; bh=jduiy8pPvVfiNX64fpfAUgd/LVwstruAF09Ltru5vPc=; h=From:To:Subject:In-Reply-To:References:Date:From; b=Nkz4QATABmmK+aB/h4J4orx4YsImjE2NYab0R36Uxr1S3aXOiQhHk0r8T15PCP7AS V4ubJe3wS4/4KEe3j9BL/0a+8DWsJmSKbeIyyplK7b4Y9WQ5OhiafX5+IQFOv0k+Kk sgITwAzNBHH082yGWYAvSvCWNdznwEH6hJpOr35npDPBeDKSSFzWsSU+xUN+cUaVQA Mu51G2pfnb//7wRNHGW50Yc8I08Gut4QdJvsEACub9kkn42VGZooPKBNkA5ZfLVwLN 2Td2P8ouzfs2rgEhIQNgyUBNaz916/1tjYyC13JOtFcYps+9IM9xAyMBTX4ULcgGfQ PQxamp4SQd9ww== To: Rich Brown , make-wifi-fast@lists.bufferbloat.net In-Reply-To: References: Date: Tue, 12 Oct 2021 16:16:43 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87mtnegwfo.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] New Realtek driver 802.11ax, with FQ-CoDel support! X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2021 14:16:46 -0000 Rich Brown writes: >> On Oct 9, 2021, at 12:00 PM, make-wifi-fast-request@lists.bufferbloat.net wrote: >> >> In the process of being upstreamed: >> >> https://lore.kernel.org/r/20211008035627.19463-1-pkshih@realtek.com >> >>> This driver named rtw89, which is the next generation of rtw88, supports >>> Realtek 8852AE 802.11ax 2x2 chip whose new features are OFDMA, DBCC, >>> Spatial reuse, TWT and BSS coloring; now some of them aren't implemented >>> though. > > This is so cool! A couple questions: > > 1) I have lost track: what drivers now incorporate FQ-CoDel? $ cd drivers/net/wireless && git grep -l wake_tx_queueath/ath10k/mac.c ath/ath9k/ath9k.h ath/ath9k/main.c ath/ath9k/xmit.c intel/iwlwifi/mvm/mac80211.c mediatek/mt76/mt76.h mediatek/mt76/mt7603/main.c mediatek/mt76/mt7615/main.c mediatek/mt76/mt76x0/pci.c mediatek/mt76/mt76x0/usb.c mediatek/mt76/mt76x2/pci_main.c mediatek/mt76/mt76x2/usb_main.c mediatek/mt76/mt7915/main.c mediatek/mt76/mt7921/main.c mediatek/mt76/tx.c realtek/rtw88/mac80211.c > 2) How can we talk about this in OpenWrt (and elsewhere...)? > - Is it correct/reasonable/sensible to say that the fq_codel wifi drivers are "good" while the others are "not-so-good" > - Does the presence of a chip/driver from 1) above indicate a more desirable device? > - Or is it more nuanced? For just the FQ-codel in driver support, yeah, I think it's fair to say that it's unambiguously "better". -Toke