From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 701B53B2A4 for ; Mon, 18 Nov 2019 05:10:34 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574071834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G45mRJb2R55hTpqWOgmQqio32gnIzC1eCmtGv4EySOk=; b=K/w1M80Mv5I7PKE50VZYTfYU4JiYY3sT34AqIF+AnTtdbIx5pK9/oLcBeIWHJcxz5eAliQ mJN1U4wo5KeWoB09a/cqKv+sOtlhZaNJCVJnKrtZ70pB9xKTiTTac2xwweOl0LdPu9DnnV 7KEEiAZI+j+xNOfNUQz7WEGams7AVpI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-dGnmRrhSO2qeywTXCfnVxg-1; Mon, 18 Nov 2019 05:10:32 -0500 Received: by mail-lf1-f69.google.com with SMTP id h3so4980443lfp.17 for ; Mon, 18 Nov 2019 02:10:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=OIQCTBj1ZZClWzpd5quqOflGEWiO+R0tbK558qeMbh4=; b=FXwma/U09D1hqoLCzGttcSmZNAkhH83hfeFrRRsHIwTfK9fN/en42imXa2HWAEoZYm YkVaQviV2uyEUUGDx+rYe1/KUD/mELwpNQH8hBc6zrRVVMNsBS0oBjm6QoacsZarM+s1 3uUCA+/CX6mgA+JNx13cjuBZUylGDmXDPAc1ajH8JU8GC7mhhokU6KyT2w7Rl1OVvEX1 01EVSWq4Bh+3E/cjPUeoW+jj0z0/oP6cK0uGglX0CZlu5lxX+gykjm4xvWSwDtbijjCO uPAC661IuoEO1/cLAg3ug7mlvA65ZnGkxcT/f3lJkTzEAbxGrZoXlNU1Ll7Tv8o2nfTf BrfA== X-Gm-Message-State: APjAAAW73SMFvCpuE6yyVjB8vymn8BWhgP7I1aYIBRTKkCLxXDwGyZYB 848uW4JGQvPsx1fyKV0taDoyQdW1GTvMtOopfK+3p2lUTlqSDwyTvfrwvoHA0QE1k4kGhXwuMaU q76iDSr5lEcV6UUYlDk0X6p9zhaTYU93Rws0= X-Received: by 2002:a05:651c:1109:: with SMTP id d9mr20056938ljo.192.1574071831439; Mon, 18 Nov 2019 02:10:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyx34G0PV/fe8D53a+QUqfm/vO0wSGhLgSfIKtC5qf0UKXzF5h1YYJhlKi/PARk15AMZvmAJA== X-Received: by 2002:a05:651c:1109:: with SMTP id d9mr20056921ljo.192.1574071831296; Mon, 18 Nov 2019 02:10:31 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id o196sm8775203lff.59.2019.11.18.02.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 02:10:30 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DF6B118190D; Mon, 18 Nov 2019 11:10:29 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless , Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes In-Reply-To: References: <157382403672.580235.12525941420808058808.stgit@toke.dk> <157382404118.580235.14216392299709793599.stgit@toke.dk> <87y2wgjas4.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 18 Nov 2019 11:10:29 +0100 Message-ID: <87muctcx62.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: dGnmRrhSO2qeywTXCfnVxg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2019 10:10:34 -0000 Kan Yan writes: >> > Given the fact that AQL is only tested in very limited platforms, >> > should we set the default to disabled by removing this change in the >> > next update? >> > >> > - local->airtime_flags =3D AIRTIME_USE_TX | AIRTIME_USE_RX; >> > + >> > + local->airtime_flags =3D AIRTIME_USE_TX | >> > + AIRTIME_USE_RX | >> > + AIRTIME_USE_AQL; >> > + local->aql_threshold =3D IEEE80211_AQL_THRESHOLD; >> > + atomic_set(&local->aql_total_pending_airtime, 0); >> Well, we have the whole -rc series to get more testing in if we merge it >> as-is. It's up to the maintainers, of course, but I would be in favour >> of merging as-is, then optionally backing out the default before the >> final release if problems do turn up. But I would hope that the limits >> are sufficiently conservative that it would not result in any problems := ) > > Sounds good. The current default limits are reasonably conservative > and are tunable via debugfs. > > I will give the v10 version of this patch serial a quick test and > hopefully we can wrap it up soon. Sounds good, thanks! Also, seems we got a 5.4-rc8 yesterday, so we have another week before the merge window. Johannes, any chance you'll get a chance to take a look at this sometime this week? :) -Toke