From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5E9623B25D for ; Mon, 22 Aug 2016 11:44:00 -0400 (EDT) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 418C361D01; Mon, 22 Aug 2016 15:43:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5E3DD61CA5; Mon, 22 Aug 2016 15:43:57 +0000 (UTC) From: Kalle Valo To: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Tim Shepard , Felix Fietkau References: <20160706193417.13080-1-toke@toke.dk> <20160805160346.10545-1-toke@toke.dk> In-Reply-To: <20160805160346.10545-1-toke@toke.dk> ("Toke \=\?utf-8\?Q\?H\?\= \=\?utf-8\?Q\?\=C3\=B8iland-J\=C3\=B8rgensen\=22's\?\= message of "Fri, 5 Aug 2016 18:03:46 +0200") Message-ID: <87mvk44xmt.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 28 Nov 2016 08:47:10 -0500 Subject: Re: [Make-wifi-fast] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Mon, 22 Aug 2016 15:44:00 -0000 X-Original-Date: Mon, 22 Aug 2016 18:43:54 +0300 X-List-Received-Date: Mon, 22 Aug 2016 15:44:00 -0000 Toke H=C3=B8iland-J=C3=B8rgensen writes: > This switches ath9k over to using the mac80211 intermediate software > queueing mechanism for data packets. It removes the queueing inside the > driver, except for the retry queue, and instead pulls from mac80211 when > a packet is needed. The retry queue is used to store a packet that was > pulled but can't be sent immediately. > > The old code path in ath_tx_start that would queue packets has been > removed completely, as has the qlen limit tunables (since there's no > longer a queue in the driver to limit). > > Based on Tim's original patch set, but reworked quite thoroughly. > > Cc: Tim Shepard > Cc: Felix Fietkau > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- > Changes since v3 (most due to Felix; thanks!): > - Correctly notify mac80211 when there are packets in the retry queue > on powersave start/stop. > - Get rid of ath_tx_aggr_resume(). > - Some readability changes and additional WARN_ON/BUG_ON in > appropriate places. This is great work but due to the regressions I'm not sure if this will be ready for 4.9. To get more testing time I wonder if we should wait for 4.10? IMHO applying this in the end of the cycle is too risky and we should try to maximise the time linux-next by applying this just after -rc1 is released. Thoughts? --=20 Kalle Valo