From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 864253B2A4 for ; Tue, 22 Oct 2019 03:14:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571728488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qwsp5QQ6bMYXnb9ux6HCdVcJSILSyF0BVLpabeoGiOo=; b=Z+9tkISNppe8bg/00mUnknBmy2+2QownJQ+nSgPrl3atO23eYaOF+j/ffEDNDCPlurgZlM KsBW0WitLGJiI3q7XJC7u7L5PFD0xUGGNs8D0J7NBsqXpCHyXheLJWfCQ/WWWvMpMsdQkq o8RB8hsRWIxaBLNYNSkyeSGtdeZpr6E= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-qW_5U4MzOraoBqr4IN3IvQ-1; Tue, 22 Oct 2019 03:14:47 -0400 Received: by mail-lf1-f69.google.com with SMTP id c27so3242719lfj.19 for ; Tue, 22 Oct 2019 00:14:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YEnLndySMbqJ6YLxHTcryFiXLrxuubnh33DpZ1uyCVw=; b=URlctT2Gw1nL+78nwoKXHNvNI1cutzLqI2LpJ13YiW55xiKGW8SFoUIQD89apIKM4J eNJXnI21TKXFQZYTK1Sy+3JIv6jTqenCWsNWTyXyGN8a2hcffZM9cnzn5JsIMZJUu15z wNHsR/0JPUdIWNf97wgiqUVxjUw/OsBaI1D0y0AcmlRl/CS5PGtNAlLHv+vOJ3LCOTEi GfyfhYe9fLu9mjisVyuvspgrec1LcOPmHvINolRIUiONLhdVXdFZbZ7yXvO3s7ASolyc F6aGV6Q/ouYJI7rZtoGjvyO/gd7eEIVWKTyyORteNFfGBUQ5Ll3yp/Me/uEQB6QQUoEb yIBw== X-Gm-Message-State: APjAAAWLGwAcAbvJMC/dabEaATkofqLbyAomlgsjPNuvmrmu06qcEraD xk6boQ97Ics/xC0reIkGI9CJ+/QrgkjkwhVd+7M8FN06TnsmEaixerI09gSCvg0XqV0YyXr36GF dRE673KWhn92llJTCp0QZPZe+x0misNMMJs4= X-Received: by 2002:a19:ee15:: with SMTP id g21mr9604033lfb.27.1571728485935; Tue, 22 Oct 2019 00:14:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwCSIOYeZTnkeEphbi//1B6x6TmIFBb5CxKOQTHtWQ/QW3TmwG4Neq6wU/IdDUdAzg548Su5Q== X-Received: by 2002:a19:ee15:: with SMTP id g21mr9604021lfb.27.1571728485759; Tue, 22 Oct 2019 00:14:45 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id p22sm8765694ljp.69.2019.10.22.00.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 00:14:45 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id EE22D1804B1; Tue, 22 Oct 2019 09:14:43 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes In-Reply-To: References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 22 Oct 2019 09:14:43 +0200 Message-ID: <87o8y9p7z0.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: qW_5U4MzOraoBqr4IN3IvQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 07:14:49 -0000 Kan Yan writes: >> + if (ieee80211_is_data_qos(hdr->frame_control)) { >> + qc =3D ieee80211_get_qos_ctl(hdr); >> + tid =3D qc[0] & 0xf; >> + ac =3D ieee80211_ac_from_tid(tid); >> + } else { >> + ac =3D IEEE80211_AC_BE; >> + } > > The tid/ac is incorrect either here or in __ieee80211_tx_status() when > tested with ath10k. The ac is set to AC_BE with test done using BK > class traffic, hence the pending airtime get updated for the wrong > txq. Huh, well that won't do, obviously :) Any idea why it might be wrong? > The rest of the patch seems to work as expected, after I did a quick > hack to release the pending airtime from ath10k_txrx_tx_unref() > instead, where the ac/tid can be directly retrieved from struck struct > ieee80211_tx. Awesome! Thanks for testing! -Toke