From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 78DE93B29E for ; Fri, 1 Dec 2017 08:42:51 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1512135769; bh=O10eXsx4AIz17WIbsEZmqfAL9f0yRIIjRTaonElNdZE=; h=From:To:Subject:Date:From; b=G3Hwe7f2HzkfMAviKjVNaL9O/Qvj5/Ql6sYm1XKSaK1kQ3TgR5/38wSQCc11MwQ0V ePrmSC42fmuV8L5tJ82AOqh7/CLy6Lv9NVMZcZWh7+WoKBttZ/NfBsyi1dAN2nzkSy tnUGitdygORHdOwUDQqBocprcFv0chJFa1SPhTP4wqqUOj5GxVYqafqw21Yhdmc68Q 1m7Tq8jTcdVXouV7Y7PJjGnmfWSwvGjiCW7w2pJWCtLIS1/fOCPa9aLFbJtxz62dox OCA5Rbu637qssVYP+0sTt1Yl6WoEK/AXRvweLFynBDnymfjh1YFVJyY4Gr8oMbB4fD YVI4LUOIxuDPA== To: make-wifi-fast@lists.bufferbloat.net Date: Fri, 01 Dec 2017 14:42:47 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87o9ni36p4.fsf@toke.dk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Subject: [Make-wifi-fast] Fwd: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 13:42:51 -0000 --=-=-= Content-Type: text/plain Seems that ath10k has gained the ability to report airtime used by clients, which hopefully will enable airtime fairness for those devices as well (once we finish moving the implementation up to mac80211). -Toke --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.1 Delivered-To: toke@toke.dk Received: from mail.toke.dk by mail.toke.dk with LMTP id UC19GUjZIFrbEgAAOr1fkg for ; Fri, 01 Dec 2017 05:23:36 +0100 Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by mail.toke.dk (Postfix) with ESMTPS id 0BCF224AB69 for ; Fri, 1 Dec 2017 05:23:35 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b=WFCAD+3v; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b=N3RoZT73 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1512102211; bh=68kis+GT2C6VadXGPc9FdwHmM2WLyg8hz83zEeewymg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WFCAD+3vZpZNT2ILtrUYZz7g7137LMUQGISzNMKOH+NZlI5Dg5i/Xpmtu+d/qmI4r mIhwRe5apy2eZfb95kkzbc8S7bWqE2fmdfkth+CxhosRqE8QqPj5lbGtcjcvJ4kPFQ /Rukn/b9do4Zbu8UsdiTLRM5X28pejFAvvHVzrqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1512102210; bh=68kis+GT2C6VadXGPc9FdwHmM2WLyg8hz83zEeewymg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N3RoZT731p8UZWwnXZDx/Wx110YWjlPFG4KR9HC1rtxelw2ZftlSxefx0drl9ARGQ 7Ye+gWHK7Z4O3oU0LsM/R4Jf06jTX0dVlSpkEfv7nVNz8Q2IgK9ySXZmYfuChR3BAh tNy+o5Xy+QpuFu+dhWZS8HUxwe9lfLyxr4XWwG5U= Date: Fri, 01 Dec 2017 09:53:30 +0530 From: akolli@codeaurora.org To: Kalle Valo Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Anilkumar Kolli , linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 In-Reply-To: <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <5080a68538fd2d883e15bacaa969661b@codeaurora.org> X-Sender: akolli@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2017-11-30 22:08, Kalle Valo wrote: > Toke H=C3=B8iland-J=C3=B8rgensen writes: >=20 >>>> +struct ath10k_10_2_peer_tx_stats { >>>> + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 flags[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le32 tx_duration; >>>> + u8 tx_ppdu_cnt; >>>> + u8 peer_id; >>>> +} __packed; >>>=20 >>> Toke, hopefully the tx_duration value here helps with ATF >>> implementation >>> using QCA988X. >>=20 >> Awesome! What's the semantics of this field? Just total >> duration spent serving that station in the reporting interval? >> Does it include retry attempts? >=20 > I have no clue :) I just noticed this while I was reviewing the patch > internally and immediately recalled our discussions at Seoul. I can try > to find out, but that will take a long time as I have way too much=20 > stuff > pending at the moment. Hopefully someone more knowledgeable=20 > (Anilkumar?) > can chime in and help. tx_duration is aggregate time duration of 4 PPDU sent to STA. FW sends these values for retry packets also. Thanks, Anil. --=-=-=--