[Make-wifi-fast] Fwd: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

[Make-wifi-fast] Fwd: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

[Toke Høiland-Jørgensen]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

Seems that ath10k has gained the ability to report airtime used by
clients, which hopefully will enable airtime fairness for those devices
as well (once we finish moving the implementation up to mac80211).

-Toke


[-- Attachment #2: Type: message/rfc822, Size: 3944 bytes --]

From: akolli@codeaurora.org
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, "Anilkumar Kolli" <akolli@qti.qualcomm.com>, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Fri, 01 Dec 2017 09:53:30 +0530
Message-ID: <5080a68538fd2d883e15bacaa969661b@codeaurora.org>

On 2017-11-30 22:08, Kalle Valo wrote:
> Toke Høiland-Jørgensen <toke@toke.dk> writes:
> 
>>>> +struct ath10k_10_2_peer_tx_stats {
>>>> +	u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	__le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	__le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	__le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	u8 flags[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> +	__le32 tx_duration;
>>>> +	u8 tx_ppdu_cnt;
>>>> +	u8 peer_id;
>>>> +} __packed;
>>> 
>>> Toke, hopefully the tx_duration value here helps with ATF
>>> implementation
>>> using QCA988X.
>> 
>> Awesome! What's the semantics of this field? Just total
>> duration spent serving that station in the reporting interval?
>> Does it include retry attempts?
> 
> I have no clue :) I just noticed this while I was reviewing the patch
> internally and immediately recalled our discussions at Seoul. I can try
> to find out, but that will take a long time as I have way too much 
> stuff
> pending at the moment. Hopefully someone more knowledgeable 
> (Anilkumar?)
> can chime in and help.

tx_duration is aggregate time duration of 4 PPDU sent to STA.
FW sends these values for retry packets also.

Thanks,
Anil.

Re: [Make-wifi-fast] Fwd: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

[Dave Taht]

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> Seems that ath10k has gained the ability to report airtime used by
> clients, which hopefully will enable airtime fairness for those devices
> as well (once we finish moving the implementation up to mac80211).

Oh, cool.

Maybe I won't regret buying these as much as I have so far.

https://www.amazon.com/Ubiquiti-Networks-UAP-AC-M-US-Wide-Area-Dual-Band/dp/B076B4ZVF2/ref=sr_1_2?ie=UTF8&qid=1511125487&sr=8-2&keywords=ubnt+uap&dpID=51-Rhp-ZYuL&preST=_SY300_QL70_&dpSrc=srch

>
> -Toke
>
> From: akolli@codeaurora.org
> Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
> To: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: Toke Høiland-Jørgensen <toke@toke.dk>,
>  ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Anilkumar Kolli
>  <akolli@qti.qualcomm.com>, linux-wireless-owner@vger.kernel.org
> Date: Fri, 01 Dec 2017 09:53:30 +0530 (13 hours, 46 minutes, 49 seconds ago)
>
> On 2017-11-30 22:08, Kalle Valo wrote:
>> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>> 
>>>>> +struct ath10k_10_2_peer_tx_stats {
>>>>> +	u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	__le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	__le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	__le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	u8 flags[PEER_STATS_FOR_NO_OF_PPDUS];
>>>>> +	__le32 tx_duration;
>>>>> +	u8 tx_ppdu_cnt;
>>>>> +	u8 peer_id;
>>>>> +} __packed;
>>>> 
>>>> Toke, hopefully the tx_duration value here helps with ATF
>>>> implementation
>>>> using QCA988X.
>>> 
>>> Awesome! What's the semantics of this field? Just total
>>> duration spent serving that station in the reporting interval?
>>> Does it include retry attempts?
>> 
>> I have no clue :) I just noticed this while I was reviewing the patch
>> internally and immediately recalled our discussions at Seoul. I can try
>> to find out, but that will take a long time as I have way too much 
>> stuff
>> pending at the moment. Hopefully someone more knowledgeable 
>> (Anilkumar?)
>> can chime in and help.
>
> tx_duration is aggregate time duration of 4 PPDU sent to STA.
> FW sends these values for retry packets also.
>
> Thanks,
> Anil.
> ----------
>
> _______________________________________________
> Make-wifi-fast mailing list
> Make-wifi-fast@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/make-wifi-fast