From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C87433B2A4 for ; Sun, 6 Oct 2019 13:40:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570383646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OplA5Eho1GIEW8dDMs+xxflTmjf1UF/kSpiSZWDT73c=; b=bPH+zztOV8JUv4+ngo7wmoDk8PJ1tcJ6eUnIG+leAdKQwOE8BHo04p9mOyTuExR6QUPPWN DnluZLdf6fUM25OvU3xFdfMG3xYqPoWz6Og2YDMGeTuH5deXF80V8fnRhi5Chn+fpe8D93 tDCtblwSjilioFpuveZ6zJeNZdB2sjE= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-u1ZXTHp2OQeyQNn7t1mh1Q-1; Sun, 06 Oct 2019 13:40:44 -0400 Received: by mail-ed1-f71.google.com with SMTP id c23so7497134edb.14 for ; Sun, 06 Oct 2019 10:40:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wZ8y88e72WyyshxxhVRkdi4DU4ry9fvzWnGuXY2vT1Q=; b=rmilBSnerO0tBP5flfvL2Ke8pGVJi5O2Yh6h2j8JkfUf0H8VrCyfPREVVhepVidmjn ELJjqnYAUb+Un/owo4yvXgMbDmumUrSWqJprBcBhSZNGCR+NAHxvBn13uxgbwcIqeDmR Txs6D1PjMASR2uFmYd399FrRrGCqx6RWPI6HasWxP9e76yN53MX6qiuPhgj3oULx13hx 4YL5vPb5P+vu3ccGGydqvAbmScmU1s3gKOoVjfH8D+gVXR5LxMWdbwsQDp3muxrY0s2Z Lt5lSORWnT3kyPCvCvGK5+881eiERokLE5tehNMVJdkgY3nDcBW3MIdH7V35V6QRqSd0 e4SA== X-Gm-Message-State: APjAAAVOlbTA8ZufAFTtLA9RZ/a+DxM0BDQ4GoY64s0ipMNBfY/GTsvX xCvNDxVeyjxlFjLzQG0wNUa1lx7s5umG7IKzwXQIzLiFHQZpVF2h5znXU2H5cT5jmLIRP2faLUU ZjRCtrKIiVDSJiK8M/RSPhfsXK88a5FYpLRQ= X-Received: by 2002:aa7:d688:: with SMTP id d8mr25510699edr.156.1570383643705; Sun, 06 Oct 2019 10:40:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxz+Mr44y1o6iTqmFxjA2C8R7UKKt5W88AlsDY6m5Zm3OCto1orWgmWTjOhIaNZywlG8943iA== X-Received: by 2002:aa7:d688:: with SMTP id d8mr25510684edr.156.1570383643450; Sun, 06 Oct 2019 10:40:43 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id g9sm1509091ejj.51.2019.10.06.10.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2019 10:40:42 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 4941718063D; Sun, 6 Oct 2019 19:40:41 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, Felix Fietkau , Yibo Zhao In-Reply-To: References: <20191004062151.131405-1-kyan@google.com> <20191004062151.131405-2-kyan@google.com> <87imp4o6qp.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Sun, 06 Oct 2019 19:40:41 +0200 Message-ID: <87pnj9n55y.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: u1ZXTHp2OQeyQNn7t1mh1Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH 1/2] mac80211: Implement Airtime-based Queue Limit (AQL) X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Oct 2019 17:40:46 -0000 Kan Yan writes: > Hi Johannes, > > Thanks for help review this patch. I will fix all style errors. > >> > +ieee80211_txq_airtime_check(struct ieee80211_hw *hw, struct ieee80211= _txq *txq); >> Why is it necessary to call this, vs. just returning NULL when an SKB is >> requested? > This function is also called by ath10k, from ath10k_mac_tx_can_push(), > which returns a boolean. > >> However, I'm not sure it *shouldn't* actually be per interface (i.e. >> moving from >> local->aql_total_pending_airtime >> to >> >> sdata->aql_total_pending_airtime >> >> because you could have multiple channels etc. involved and then using a >> single airtime limit across two interfaces that are actually on two >> different channels (e.g. 2.4 and 5 GHz) doesn't make that much sense. >> >> Actually, it does make some sense as long as the NIC is actually >> channel-hopping ... but that's in the process of changing now, there's >> going to be hardware really soon (or perhaps already exists) that has >> real dual-band capabilities... > > That's a good point. I haven't thought about real simultaneous dual > band chipset and such chipset do exists now. Is RSDB support coming to > mac80211 soon? Just curious if it will be just virtual interfaces or > something else. I chose "local" instead of "sdata" thinking about the > case of several virtual interfaces (AP, STA, MESH) operates in the > same channel, then the interface total could be a better choice. > > I am ok with moving the "aql_total_pending_airtime" into sdata, but > afraid that's not the most optimal choice for the case of multiple > virtual interfaces operates in the same channel. > Maybe we could leave it in "local" for now. What do you think? I'd lean towards keeping it in 'local' for consistency with all the other airtime stuff. For now, I think having multiple SSIDs on the same radio is more common than the reverse (multiple bands on a single radio). In particular, the per-group airtime fairness stuff is definitely designed on the assumption that all BSSes share the same band. So if and when we start supporting true multi-band devices we'll have to change these things anyway. So might as well keep everything together so it all gets fixed :) -Toke