From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 342283B2A4 for ; Fri, 3 Feb 2017 08:21:06 -0500 (EST) Received: from mail.toke.dk (localhost.localdomain [127.0.0.1]) by mail.toke.dk (Postfix) with ESMTPS id C20A962D46; Fri, 3 Feb 2017 14:21:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1486128064; bh=rs2xBJcJiveJFv6J/Kvmx6y9wdlifco5KPrN3XPa8Xw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CeIHsmtMiLJsCHua/5TwQoElE97XOJ+Qah35H+6ExTPPp0i0TIaaTCR+euu/QAaKK Fd8HCSsgLC9sFdgta/XEHNulyCRzBFQCN7KgvXbomTvQDxDglPMlBJlb8aOl0vnLer +y3G11cwhp/TECEh6w0jYM2B9Y5zkHSy8rKzOyI6lyKUPdJWaUuCrsj5aan+pzDzEE LMJUDkJgof8kxvtt8KOeLbFGq+BHKGaiQGopnuzBxg1t8nPLimSG63lCJO23G9j75u lFP/t6+VWiNtr9fvJ0Yg1/8S3Vsn22DFVB9LD1GkzTfGGxC7iwmOx0qSh6o1MUh6DD cdrZOaRqhBgDQ== Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 718F818367; Fri, 3 Feb 2017 14:21:03 +0100 (CET) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Dave Taht Cc: make-wifi-fast@lists.bufferbloat.net References: Date: Fri, 03 Feb 2017 14:21:03 +0100 In-Reply-To: (Dave Taht's message of "Thu, 2 Feb 2017 15:47:38 -0800") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87poiz1kcg.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [PATCH] killing retries harder, perhaps X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 13:21:11 -0000 Dave Taht writes: > ATH_TXMAXTRY is now unused. > > ATH_MAX_SW_RETRIES is insanely high by default. > > I finally have some good (well, horrible) data in a consistently noisy > environment and would like to try knocking this down a little in a > future test run. There's smarter ways to do it (like, if you are at > the lowest rate, retry once, higher rates, 4). > > I have tried in the past values as low as 2 for soft retries. > > diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h > b/drivers/net/wireless/ath/ath9k/ath9k.h > index 331947b..304976d 100644 > --- a/drivers/net/wireless/ath/ath9k/ath9k.h > +++ b/drivers/net/wireless/ath/ath9k/ath9k.h > @@ -91,8 +91,7 @@ int ath_descdma_setup(struct ath_softc *sc, struct > ath_descdma *dd, > #define ATH_RXBUF 512 > #define ATH_TXBUF 512 > #define ATH_TXBUF_RESERVE 5 > -#define ATH_TXMAXTRY 13 > -#define ATH_MAX_SW_RETRIES 30 > +#define ATH_MAX_SW_RETRIES 4 Note that this is not tested until *after* the initial retry chain has been exhausted. So Minstrel may still (and usually will) define a retry chain that is a lot longer than 4; meaning that the net effect of this change is that you'll just drop any packets that are kicked back to the driver after the retry chain fails... Not that this is necessarily a bad thing, just something to keep in mind. -Toke