From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 899213B25D for ; Thu, 11 Aug 2016 08:34:48 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk B379840D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1470918885; bh=Yj3tsuvyP4mf0ibfAaQHspZjqL7LJsPdFXsL1u6iDI4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hXqzuz7q1ttdHZIUc37N7X8S4VG+wVuaF8vaGZpaJy3sEcfXG6mrfSF4ZOpfD+RVS PxfsNuONE86sIlrwHAC+NAtiMUxCfpSobOjXbh9t5mfdofLbyjMyidPIX7/H/DG3Ys ogq36mQ3c5sDISwPswVo/J8RX8V20NjGLz9Q/PhY= Sender: toke@toke.dk Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C0D48569A; Thu, 11 Aug 2016 14:34:44 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, Michal Kazior References: <20160720145442.1098-1-toke@toke.dk> <1470918167.12075.2.camel@sipsolutions.net> Date: Thu, 11 Aug 2016 14:34:44 +0200 In-Reply-To: <1470918167.12075.2.camel@sipsolutions.net> (Johannes Berg's message of "Thu, 11 Aug 2016 14:22:47 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87popf8owr.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH] mac80211: Keep CoDel stats per txq, export them in debugfs. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 12:34:48 -0000 Johannes Berg writes: >> @@ -137,18 +137,20 @@ static int aqm_open(struct inode *inode, struct >> file *file) >> =C2=A0 len +=3D scnprintf(info->buf + len, >> =C2=A0 =C2=A0info->size - len, >> =C2=A0 =C2=A0"* vif\n" >> - =C2=A0"ifname addr ac backlog-bytes backlog- >> packets flows overlimit collisions tx-bytes tx-packets\n"); >> + =C2=A0"ifname addr ac backlog-bytes backlog- >> packets flows drops marks overlimit collisions tx-bytes tx- >> packets\n"); > > It seems to me that you have to change the buffer length to take this > into account? Haven't run into issues with running out of buffer space in my testing. But yeah, guess that could become an issue. >> =C2=A0 list_for_each_entry_rcu(sdata, &local->interfaces, list) { >> =C2=A0 txqi =3D to_txq_info(sdata->vif.txq); >> =C2=A0 len +=3D scnprintf(info->buf + len, info->size - len, >> - =C2=A0"%s %pM %u %u %u %u %u %u %u %u\n", >> + =C2=A0"%s %pM %u %u %u %u %u %u %u %u %u >> %u\n", >> =C2=A0 =C2=A0sdata->name, > > Why is it this way anyway? It'd seem nicer to move the content of this > into the per-netdev subdirectories, and then it becomes a lot simpler > code too (yes, at the expense of some userspace, but still) Yeah, makes sense. Can do a larger reorg moving things into the per-netdev and per-station directories instead. >> =C2=A0 =C2=A0txqi->txq.ac, >> =C2=A0 =C2=A0txqi->tin.backlog_bytes, >> =C2=A0 =C2=A0txqi->tin.backlog_packets, >> =C2=A0 =C2=A0txqi->tin.flows, >> + =C2=A0txqi->cstats.drop_count, >> + =C2=A0txqi->cstats.ecn_mark, >> =C2=A0 =C2=A0txqi->tin.overlimit, >> =C2=A0 =C2=A0txqi->tin.collisions, >> =C2=A0 =C2=A0txqi->tin.tx_bytes, > > Do you really want to add these in the middle? Seems that if you add > them at the end, you at least have *some* way of keeping this working > with older versions? Well I though they should be logically grouped with overlimits, and was counting on no one actually parsing these yet. Guess if the information is moved that becomes moot. Will re-send; thanks for the feedback :) -Toke