From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E63273B29D for ; Fri, 22 Nov 2019 07:56:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574427403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7iaZa3lWb/liQ3KOyt+Q/aYBEcpYpaL7KReyXpriBQ=; b=XBIhBLr1a/XOa+BcpaS+B/7VWUSnpmZD+zlOxg4MkPlEUkgsqlwJAHVVTvhuAX7e22WLiY PsPXqOz9KAEeDlGV8L9s/lP87BcYORDYacFHM1tHwXr9bgVmKx/5qgQXpRa/JCe3h1RDQ3 WGlTSWZ3RyBurWnBd89Cq0xIsvRXfnY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-lg2q0PcPOUm726UNFztE_A-1; Fri, 22 Nov 2019 07:56:39 -0500 Received: by mail-lf1-f72.google.com with SMTP id t6so1750362lfd.13 for ; Fri, 22 Nov 2019 04:56:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=ztfKKq9p/dWzxUE4rOgUYoWjyWYtyvbDJUKl0X867xs=; b=thp1qUxBw1RUMqVouR/x4YWdTmFJp+Lp2TuHHLkjAOy4iOYZ03UKUy4pOf2hhto8QM QdpGv9+Ophv05Fn865c94CTNaLijVfkfG9s5vA3GTSuKefEmQ0bLKHIT0Y5TMalyfHEv Ucy40RQpbo/AG0DD8HchCNcsjjgEB6cj5SQ2ZsIkCR/O2uCyh/mDMOTHf9KkaIjUuqmI 3m7iEzn2KOda2k/N/PU/98dsv9/QTDy31QcetBXSho3GvCxnpGFnHaPt8JmcfYyhSeTd wvOU5ZyLEhls6DpLk15ilppO3FR8t6asP5ec5V/tAabiEWFkbZPbaHKqcZURgBko21rS mkfw== X-Gm-Message-State: APjAAAUOIDYYPkJ+3pTutJdQVpYdCNNsgMJDWVw4vFrzuQ/Ki/wQpzSZ Fjs5y/ZIFfftKgOlPzxQvYMcT8yDlbi3Z/Cd1mTkb7YbYy26eKmIoBSxsRPB6FuSfhSZLsIsvjy dc+ko86aKsa45VxEwytCTFp4WXkN9M/cqpdw= X-Received: by 2002:ac2:54b1:: with SMTP id w17mr12021831lfk.128.1574427398325; Fri, 22 Nov 2019 04:56:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxykIhYXij1dTIeYKxDSe8XNN/wtOxQL4PwKS6gv6ZYDsmTtZv/ytTm5HBebEkq4urkt9c2YQ== X-Received: by 2002:ac2:54b1:: with SMTP id w17mr12021817lfk.128.1574427398199; Fri, 22 Nov 2019 04:56:38 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id u184sm2950626lja.86.2019.11.22.04.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 04:56:37 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id EB1771800B9; Fri, 22 Nov 2019 13:56:36 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com In-Reply-To: References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 22 Nov 2019 13:56:36 +0100 Message-ID: <87r2203w8r.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: lg2q0PcPOUm726UNFztE_A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2019 12:56:44 -0000 Johannes Berg writes: > On Mon, 2019-11-18 at 22:06 -0800, Kan Yan wrote: >>=20 >> +#define HE_GROUP_IDX(_streams, _gi, _bw)=09=09=09=09\ >> +=09(IEEE80211_HE_GROUP_0 +=09=09=09=09=09\ >> +=09 IEEE80211_HE_MAX_STREAMS * 2 * (_bw) +=09=09=09\ >> +=09 IEEE80211_HE_MAX_STREAMS * (_gi) +=09=09=09=09\ >> +=09 (_streams) - 1) > > I'll also fix that to be " * 3" instead of 2, since there are 3 possible > _gi values. Ah yes, good catch, thanks! -Toke