From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AC8673B25E for ; Mon, 5 Sep 2016 18:01:29 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk DC1DE4161D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1473112887; bh=SbDlWFfSwjiAze4cvBostIQKTizBNOqN9Gc4wtXZLFU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hMJawOglxRnE5bQj+WGU92XP2LElEyZAra8/xws7NVV1V1LpDpSMlRd5VZFiWSjt9 n/pw5zja94Qa/n22PWszH7jcRszx6wU837HQMX5LYbzSf7orA9kEcJXYpNvgfK/+cj IyAjvTeFbJJKlbX4WRy3si9os9mw7NSFR/qhjuOg= Received: by alrua-karlstad.karlstad.toke.dk (Postfix, from userid 1000) id 2EBAB82E339; Tue, 6 Sep 2016 00:01:27 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Dave Taht Cc: make-wifi-fast@lists.bufferbloat.net References: <20160902134104.29309-1-toke@toke.dk> <20160905113042.22271-1-toke@toke.dk> <87oa4249hf.fsf@toke.dk> <8760qab6ly.fsf@toke.dk> <87oa429iu3.fsf@toke.dk> <87d1ki9gzw.fsf@toke.dk> Date: Tue, 06 Sep 2016 00:01:27 +0200 In-Reply-To: <87d1ki9gzw.fsf@toke.dk> ("Toke =?utf-8?Q?H=C3=B8iland-J?= =?utf-8?Q?=C3=B8rgensen=22's?= message of "Mon, 05 Sep 2016 23:25:07 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87r38yqa4o.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v7] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 22:01:29 -0000 Toke H=C3=B8iland-J=C3=B8rgensen writes: > Dave Taht writes: > >>> Ah, no, those are not panics, those are warnings being triggered by the >>> fast_tx pointer going while the packet was queued. Now, the >>> xmit_fast_finish() function doesn't actually use that for anything other >>> than crypto key configuration, so it would probably be feasible to get >>> rid of that check in the dequeue path. >>> >>> How many of those warnings do you see? >> >> I'm not crazy, I run the rrul test at the conclusion of the run. Which t= his was. >> >> I'll go run it on a fresh boot but... >> >> dmesg | grep 'cut here' >> >> [ 707.011531] ------------[ cut here ]------------ >> [ 707.343296] ------------[ cut here ]------------ >> [ 707.676275] ------------[ cut here ]------------ >> [ 708.009204] ------------[ cut here ]------------ >> [ 708.342138] ------------[ cut here ]------------ >> [ 709.247082] ------------[ cut here ]------------ >> [ 709.580053] ------------[ cut here ]------------ >> [ 709.913023] ------------[ cut here ]------------ >> [ 710.245975] ------------[ cut here ]------------ >> >> Also attached. >> >>> And what do you have to do to get >>> traffic to flow again? >> >> Seems to come back after a while. > > Right. Put up a bunch of new images (the ones with version +3). > Completely untested, but should get rid of the need for the fast_tx > pointer. See if you can blow those up? :) BTW, if you do test these, please test them with crypto on (as well). That's where the largest potential for things blowing up is. :) -Toke