From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id F1DF83B29E for ; Fri, 25 Jan 2019 08:31:16 -0500 (EST) Received: by mail-ed1-f68.google.com with SMTP id o10so7343015edt.13 for ; Fri, 25 Jan 2019 05:31:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=oW0YjdioBzygfQLIXbGcfk9XwuMvEyBwg03MuEkyQ4U=; b=JxmPtlpseeFlqaexZ3TjA8uhHTFsu9El4MLNndTWqkivNfHFiM7QbJ/8zXGeJY+MuY 4sOfWCWnxzDLQE9J5iAaZQ8n6uVz+8gO03WelXMq7Fa9t0jEjH4m2vteR9VuzJE4Ervm EchMzFs4PMsh8TLerLahe/djMdhTrIoJLnvH3mDk8brMVQnC39imedQHhozup/JwKuiK 2RMCc7WL9kUhQNd5lB6c30PMvoj3F/BeYTHGlZRnjhBBHVMCdQFYDms5NAXBVhBEtYzl JdZKhxsUTm0I4hklYdeIoluSp4ULCbfxM7hec+7IEKUyapritA9sVM/O9F6kRuOfN1Nr 8JQQ== X-Gm-Message-State: AJcUukdk+oFsIsifhUaGG/NCbqCDPab9J8QNGk6GHJJZwbH1djYT+2JV 3upvUpfp4tr6eD2I2v9Iz1ei+Q== X-Google-Smtp-Source: ALg8bN454CPKq51bh99h0FpNN22O7bH5jDCgmoeIW6xcle6mocUol8sbeBAAD+69DI6dkuxb4SkZcw== X-Received: by 2002:a17:906:4058:: with SMTP id y24mr7330628ejj.230.1548423076074; Fri, 25 Jan 2019 05:31:16 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id g31sm11462866eda.96.2019.01.25.05.31.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jan 2019 05:31:15 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 89292180327; Fri, 25 Jan 2019 14:31:14 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , linux-wireless@vger.kernel.org Cc: Rajkumar Manoharan , ath10k@lists.infradead.org, make-wifi-fast@lists.bufferbloat.net In-Reply-To: <4f4eab34a995000d230c8b99cb6cff3f9dfd5c64.camel@sipsolutions.net> References: <20190122142019.21417-1-toke@redhat.com> <20190122142019.21417-2-toke@redhat.com> <4f4eab34a995000d230c8b99cb6cff3f9dfd5c64.camel@sipsolutions.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 25 Jan 2019 14:31:14 +0100 Message-ID: <87sgxgc199.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 13:31:17 -0000 Johannes Berg writes: >> +void ieee80211_schedule_txq(struct ieee80211_hw *hw, >> + struct ieee80211_txq *txq) >> + __acquires(txq_lock) __releases(txq_lock) >> +{ >> + struct ieee80211_local *local = hw_to_local(hw); >> + struct txq_info *txqi = to_txq_info(txq); >> + >> + spin_lock_bh(&local->active_txq_lock[txq->ac]); >> + ieee80211_return_txq(hw, txq); >> + spin_unlock_bh(&local->active_txq_lock[ac]); >> > Maybe v6 had txq->ac here instead of just ac which doesn't compile ;-) > > I fixed it up, but I hope you tested a compiling version :P Ah, right, thanks for fixing it! I think this was an artifact of moving things around while rebasing for submission (I have another patch on top of this series that I need to test first). So yeah, I definitely have a version in my tree somewhere that actually compiles ;) -Toke