From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 14F233B2A4 for ; Sun, 12 Nov 2017 09:40:29 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1510497625; bh=D0dShtCOFNlJq+4MLVebq5zBeg03Pl+9jUZbYc/VW6c=; h=From:To:Subject:In-Reply-To:References:Date:From; b=bv4Fb2HkCLF70YFB6KpxjwPz+wNFQVo1vPwSGe0heO4Ux7NOzxEWmQ1fhMsv2wNAZ O5w3o1nE4r1/n/Ye2cqDQ05sOJYJvOHbgsZkk/101CHc2HOeICNj1I2kiD0VfULGv2 C+tbIGTsQNaWd61LIzXQePNlABB4hAtn/vm15P4mhs6nL8+4NyJvBzXC80C+DM/cTR XTdLT7noozNcpuGO2m8GIXyo4R70JleQB6ayvhc9M1JWIWQ4lE1N+ZjNPM2Sjq9Xt3 PO5/T7OFD6rsmjxY2ROKZtNEd0HDgJbpXtsZI+5916gkCDByWsPguPygWRq3sZZbdM bgqnelK8FTGOw== To: Felix Fietkau , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org In-Reply-To: References: <20171110004839.7478-1-toke@toke.dk> Date: Sun, 12 Nov 2017 23:40:12 +0900 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87shdjpnlf.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v2] ath10k: Re-enable TXQs for all devices X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2017 14:40:29 -0000 Felix Fietkau writes: > On 2017-11-10 01:48, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the >> mac80211 TXQs for some devices because of a theoretical throughput >> regression. The original regression report[1] was related to fq_codel >> qdisc drop performance, which was fixed in >> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen >> the TXQ-related regression, so it should be safe to re-enable TXQs. > That commit is unrelated to the fq/codel implementations in mac80211, > since mac80211 with txq does not use qdisc. Yup. Which is why it's odd that the initial bug report referred to this; that would indicate that the regression had nothing to do with TXQs in the first place, and we could have merged this ages ago? -Toke