From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id EED283B260 for ; Wed, 6 Jul 2016 10:45:56 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 95C7B40472 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1467816354; bh=1afqCL9yocSnWHLeJWHobh3Xx6/ajSxFlF9LV82GiuM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Jmdhj8z+0Ox4EW6VoNwsf5zxMfJeNLQ+XOJTXeOL+6XbEMgFvAuvZuZGS80320Sv/ ri/qhqFuhox1KmXlsTgVN74cW8aJ/yQrOwuwIppBG2eQZTe+ovS4JWo3jAhXOwQcPb PGzDp5QzTDgWs8RLpapH0FnBbfurdCKgGDfu6AI4= Sender: toke@toke.dk Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 99D936327E; Wed, 6 Jul 2016 16:45:52 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau Cc: Tim Shepard , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org References: <87lh1hnvn6.fsf@toke.dk> <2c4c9821-fea6-fc95-f6a3-cf95e703cce6@nbd.name> Date: Wed, 06 Jul 2016 16:45:52 +0200 In-Reply-To: <2c4c9821-fea6-fc95-f6a3-cf95e703cce6@nbd.name> (Felix Fietkau's message of "Wed, 6 Jul 2016 15:23:49 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87vb0in7tr.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [PATCH] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 14:45:57 -0000 Felix Fietkau writes: >> Well, presumably the upper layers won't try to transmit anything through >> the old TX path if the start/stop logic is implemented properly. The >> chanctx code already seems to call the ieee80211_{start,stop}_queue() >> functions when changing context, so not sure what else is needed. Guess >> I'll go see if I can provoke an actual triggering of the bug, unless >> Felix elaborates on what he means before I get around to it (poke, >> Felix? :)). > Then I guess the logic in ath_tx_start was a leftover from a time before > some queue related rework happened to the chanctx code. > In that case you can simply remove the chanctx related software queueing > stuff from ath_tx_start. Awesome. I'll double-check that I can't get the WARN_ON to trigger, then send a v2 :) -Toke