From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2C7C43B25D for ; Fri, 8 Jul 2016 11:53:42 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk ABE3240472 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1467993219; bh=4uCvjGJlUrZq8dr9BqRRqBQ60i3G0MT7PTgdKcccrjI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cgZYKXFrPsQwUcChUDcTO+c+fBodE6hJ2pviJ/9QODynlA3ye2YpvrCbPO/Ho9Ln6 aDxcTHPoenyAm0SR/gn+erm/fFc2QmdBepoL576j6ItI5Wz3jKyJ538e61+H/DeqMc oChVYTbaznnIPh0o/+PEV4J1Xk7NpR/egDE2LM3A= Sender: toke@toke.dk Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 9237663D45; Fri, 8 Jul 2016 17:53:38 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Kalle Valo Cc: , , , Tim Shepard , Felix Fietkau References: Date: Fri, 08 Jul 2016 17:53:38 +0200 In-Reply-To: (Kalle Valo's message of "Fri, 8 Jul 2016 16:26:54 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87wpkwktx9.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 15:53:42 -0000 Kalle Valo writes: > Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> This switches ath9k over to using the mac80211 intermediate software >> queueing mechanism for data packets. It removes the queueing inside the >> driver, except for the retry queue, and instead pulls from mac80211 when >> a packet is needed. The retry queue is used to store a packet that was >> pulled but can't be sent immediately. >>=20 >> The old code path in ath_tx_start that would queue packets has been >> removed completely, as has the qlen limit tunables (since there's no >> longer a queue in the driver to limit). >>=20 >> Based on Tim's original patch set, but reworked quite thoroughly. >>=20 >> Cc: Tim Shepard >> Cc: Felix Fietkau >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > Nice work. Thanks :) > Because this is such a significant change, and to maximise testing > time, I'm planning to queue this for 4.9 (so I would apply this to > ath-next in 3-4 weeks after the merge window closes). But anyone who > wants to test this can use master-pending branch from my ath.git tree > (uses wireless-testing as the baseline). Sounds good? Sounds good to me. I'm planning on backporting this and Michael's mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE. Hopefully that will get it some more testing as well. > Testing and review feedback very welcome! My own evaluation results are here: https://blog.tohojo.dk/2016/06/fixing-the-wifi-performance-anomaly-on-ath9k= .html -- I see aggregate throughput to multiple stations improve by a factor of ~3 and latency under load decrease by a factor of ~10 now that we can take advantage of the mac80211 FQ-CoDel patches. -Toke