From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1177F3CB38 for ; Fri, 28 Sep 2018 03:51:58 -0400 (EDT) Date: Fri, 28 Sep 2018 09:51:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1538121116; bh=vtK1zDr0EAG5AZ4i9XMILu7fJqnYCpBb3LDf8Hhyxj8=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=uw1gTQ71d+Rm0VneTHf3w60LZUSrtePgOhCkym1dFIdoDE+ej5DiYVKBpCVvUdbrv ek3SuN8U9EGhZ4IFXydxLmuMpsvDeYpDpIWUlWOqCOrOnHfN6JP3hefU4gIEIXU21A 0UeVehstKjR93Dqm90exo4aZxLWveHzETPKmGmWGYJ3+g+xclicAOKxx5KN+Fulbkh bjMaMulfO3/JNa5otBJOlLEZbA3lTOCOqthBHty5iuf3BVy890qkEsqo587l09xOCy mCE1flFj9uEjYAAc+tIbX09DpXjlArtosG34GUliVdWeZrTIHpk8Y3EbUplgCbjgwa kYbM+TXiTuqeQ== In-Reply-To: <863bc54fbf04441d38dd53f523300a7e@codeaurora.org> References: <153711966150.9231.13481453399723518107.stgit@alrua-x1> <153711973134.9231.18038849900399644494.stgit@alrua-x1.karlstad.toke.dk> <826b6251746ee4d280d532f4ecdc5aa3@codeaurora.org> <87pnx0haud.fsf@toke.dk> <8f7145bf5abe50194bced025a5e739b9@codeaurora.org> <863bc54fbf04441d38dd53f523300a7e@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: Rajkumar Manoharan CC: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, Felix Fietkau , Kan Yan , linux-wireless-owner@vger.kernel.org From: =?ISO-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <93015743-5D16-4D79-948F-E2F46CF2450A@toke.dk> Subject: Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 07:51:58 -0000 On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan wrote: >On 2018-09-26 17:09, Rajkumar Manoharan wrote: >> On 2018-09-26 02:22, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>> Rajkumar Manoharan writes: > >> :( Yeah=2E=2E=2E I got confused with attached soft lockup in ARM platfo= rm=2E >>=20 >Toke, > >Cause for the soft lockup exposed in multi client scenario is due to >mixed order of fq_lock and active_txqs_lock=2E In wake_tx_queue or=20 >push_pending >case, driver acquires active_txq_lock first by schedule_start and=20 >followed by >fq_lock in tx_dequeue=2E The same order should be maintained in sta=20 >cleanup=2E >Below change fixed the issue=2E Ah, great find! I'll fold this into the next version, thanks! -Toke