From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 485733BA8E for ; Mon, 7 May 2018 17:30:35 -0400 (EDT) Date: Mon, 07 May 2018 23:30:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1525728632; bh=MUIZRumKgcnkMbSiLJthEgDJUQ6z2zGSeSvMYL9UDbU=; h=Date:In-Reply-To:References:Subject:To:From:From; b=U5PaVPlYeGLuZ3qjUyfbExAz8v4VgmyU5pa96+nb6hKFfKFK5lBfQG4aYvmwzN5yP vPoL3479a1+UxkCF6giDMkRUZVXunmTIHmKuQ477Hegve+8KGadNgcOsfw7tQeZIKK 0rlAjiM305N6+8rHsocbjQ3E/D3ABQlJlTppAwIgYG6SoGbuXkIVQQvZp2gS1xxRRO wgwlrRR4p8hG88amqfkphZrNVShuOpCCAFL3Akj/8OJbDHcPBcpiG6/tVT/+qaQ2sd bo+5Pnjsl3C17Po+lN/E1sON8bsxtGic/7Ywoq2rw8F9eKB81IhsNHPQrwQMocT4lV NhUEplW7LkKWQ== In-Reply-To: <1525728090.6222.1.camel@sipsolutions.net> References: <20180219170224.14816-1-toke@toke.dk> <20180219170224.14816-3-toke@toke.dk> (sfid-20180219_180319_201142_47E9DB27) <1525728090.6222.1.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: Johannes Berg , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org From: =?ISO-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= X-Clacks-Overhead: GNU Terry Pratchett Message-ID: Subject: Re: [Make-wifi-fast] [PATCH 2/3] iw: Print TXQ statistics for stations and interfaces X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 21:30:35 -0000 On 7 May 2018 23:21:30 CEST, Johannes Berg w= rote: >On Mon, 2018-02-19 at 18:02 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >>=20 >> + if (header && tid >=3D 0) >> + pos +=3D snprintf(buf, buflen, "\n\t\tTID\tqsz-byt\t" >> + "qsz-pkt\tflows\tdrops\tmarks\toverlmt\t" >> + "hashcol\ttx-bytes\ttx-packets"); >> + else if (header) >> + pos +=3D snprintf(buf, buflen, "\n\t\tqsz-byt\t" >> + "qsz-pkt\tflows\tdrops\tmarks\toverlmt\t" >> + "hashcol\ttx-bytes\ttx-packets"); >> + >> + if (tid >=3D 0) >> + pos +=3D snprintf(pos, buflen - (pos - buf), "\n\t\t%d", tid); >> + else >> + pos +=3D snprintf(pos, buflen - (pos - buf), "\n\t"); >> + >> + txqinfo =3D txqstats_info[NL80211_TXQ_STATS_BACKLOG_BYTES]; >> + if (txqinfo) >> + pos +=3D snprintf(pos, buflen - (pos - buf), "\t%u", >> + nla_get_u32(txqinfo)); > >since the header is fixed, shouldn't all of these get an else branch >that just prints a tab or so? Ah, right, good point=2E Didn't think about what would happen if any of th= e fields were actually omitted=2E Will fix that as well :) -Toke