From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9D98E3B45E for ; Mon, 18 Apr 2016 09:36:25 -0400 (EDT) Received: by mail-wm0-x230.google.com with SMTP id l6so21900435wml.1 for ; Mon, 18 Apr 2016 06:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=8hgHxLjHG8t7JhlyYSn8j052ZttyBjpW6jxzAU5CcCk=; b=39fn5ZSYXhvO9JQR6cPdl3YAS7hdr8wRZ7WuP2jgMYzD+kL9XSNkwhNz2pTa4rH7N+ +FLH7ghd5CTXmCLQZbo4dO5gcpNCNdnJf2exsaOCLe5hVBeO871Uxw4xlW+YYzH6m3hU zXmztxbcALi6kjQGjUylD8Q28ouAiWvwpAl1Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=8hgHxLjHG8t7JhlyYSn8j052ZttyBjpW6jxzAU5CcCk=; b=d9zKgPkXDXfEFSVuEOZKxozsNBfn5UFvOv+AycnSpaNbhI+t0VNTvLvQY6TNCECFAp YJ9mTwzEBLMHkiqb6obFd+Jnk6RKDz5tP3q2CYNucug+sIU5FvOc1ICwgA4kSj4z0jzs pvlztu/xPlT//7fNWcujJJByZf0TSuMXmT2XXsj03QX9a9F/lsOIPLHSs5QXBt1doNZr 8ptO2N9jG8BE0xMIJUYnskMdNoUEKnB2IKjxaYWbLiWpchEXE1EqnoADAMh6XJxasuSl YmxJN2BEBCFNJzYqMnK0ApjIQ7/BQgOvMYW83Pwfeath5ai/C5dMPG3F2crx6FPKbz5z Q8Cw== X-Gm-Message-State: AOPr4FUych9r2PNJ8cpI8PIZCwecPHAr024yQ6DmPTRVSCf96yIp2QRRhietSBSDh0ugBweFZkuAtuczeYrzxZ/GU6APpU3NmqnLurGniXzvxHnJm1gX3wCJNTfMUlN78B7/d5dC2/Ln1shT69KQSqwclIRku9aTTsJvsQ== MIME-Version: 1.0 X-Received: by 10.194.92.132 with SMTP id cm4mr19798725wjb.25.1460986584736; Mon, 18 Apr 2016 06:36:24 -0700 (PDT) Received: by 10.194.115.3 with HTTP; Mon, 18 Apr 2016 06:36:24 -0700 (PDT) In-Reply-To: <1460982672.10638.111.camel@edumazet-glaptop3.roam.corp.google.com> References: <1459420104-31554-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-3-git-send-email-michal.kazior@tieto.com> <1460845384.2075.27.camel@sipsolutions.net> <1460845552.2075.28.camel@sipsolutions.net> <1460982672.10638.111.camel@edumazet-glaptop3.roam.corp.google.com> Date: Mon, 18 Apr 2016 15:36:24 +0200 Message-ID: From: Michal Kazior To: Eric Dumazet Cc: Johannes Berg , make-wifi-fast@lists.bufferbloat.net, linux-wireless , codel@lists.bufferbloat.net, Avery Pennarun Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-DomainID: tieto.com Subject: Re: [Make-wifi-fast] [Codel] [PATCHv3 2/5] mac80211: implement fair queueing per txq X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 13:36:25 -0000 On 18 April 2016 at 14:31, Eric Dumazet wrote: > On Mon, 2016-04-18 at 07:16 +0200, Michal Kazior wrote: > >> >> I guess .h file can give the compiler an opportunity for more >> optimizations. With .c you would need LTO which I'm not sure if it's >> available everywhere. >> > > This makes little sense really. Otherwise everything would be in .h > files. > > include/net/codel.h is an include file because both codel and fq_codel > use a common template for codel_dequeue() in fast path. > > But net/mac80211/fq.h is included once, so should be a .c FWIW cfg80211 drivers might become another user of the fq/codel stuff in the future. Arguably I should make include/net/codel.h not be qdisc specific as it is now (and hence re-usable by mac80211) and submit fq.h to include/net/. Would that be better (it'll probably take a lot longer to propagate over trees, no?) > > Certainly all the code in control plan is not fast path and does not > deserve being duplicated. Good point. The fq init/reset stuff is probably a good example. However if I were to put fq.h into include/net/ where should I put the init/reset stuff then? net/core/? Micha=C5=82