From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 871D23B25E for ; Mon, 9 May 2016 08:28:54 -0400 (EDT) Received: by mail-wm0-x236.google.com with SMTP id n129so135600748wmn.1 for ; Mon, 09 May 2016 05:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=B5REncta3go061ZXmk2lZGBIFf1DmmZWMO5gfVrPdYg=; b=CycwWPbRwc8FhzQYqd2cG+LBoJAuninJYo2c+1lBk/pSS0IskeYJbuvsqpPEOK02WO NZseN+a0RkvddjbNU/uzz1b04o9wN1SnLmMYMSrRwcP9YMFwTdZOnOi67AN5nBiRPj7P AvH4HZUO5bK0DhyNJnvZyac8g7Wk+X/Yls+0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=B5REncta3go061ZXmk2lZGBIFf1DmmZWMO5gfVrPdYg=; b=TA7czMC3HcQd0EKVjmf5CNxxZAM6nHkizUuS68r7NQ/MW6qupU9inYF3ALdaNGnIlY 3ABHtKTyWl5qtDbJfkt7Et/zyBuDBZPnKPrU+ZqFCSU/SR2REzVjrotlaIFoL0bdnOC+ /dkmNOv6PPOZdc4uRVtDUIDsuzk+FgApy3YA7RML6gFzJ8pYOu6LiGVrWRA5mmda8mBf 70BijLm3tItdw1eHCiq1IkjeOUafJaEGmdbsX8m5cGflycioksxj2lzFoqLFtoiBQPls G+L95Ho9MK08Pds7s7jp37eieMF3dJ2OyILVE4UA3oI+9op+EMMZ16vdWJCQbRJYk2n2 P5mw== X-Gm-Message-State: AOPr4FVJJba1ObVDddHoHGCWBLKIhh6VgI6xEmfGomOLaA2BPEjuWXHM3prw+4w2GZyMqyeuWFM6OiOb+f5Y47e+b16anImVsQFRo5RrHGeUuo5cYhdVGvVdS7iWW/3gIKec9uGbdZHib0hp7NxBHAnBfj6UTJ9hgpN9ew== MIME-Version: 1.0 X-Received: by 10.28.45.129 with SMTP id t123mr10927318wmt.71.1462796933586; Mon, 09 May 2016 05:28:53 -0700 (PDT) Received: by 10.194.65.6 with HTTP; Mon, 9 May 2016 05:28:53 -0700 (PDT) In-Reply-To: <1462446039-1070-2-git-send-email-michal.kazior@tieto.com> References: <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1462446039-1070-1-git-send-email-michal.kazior@tieto.com> <1462446039-1070-2-git-send-email-michal.kazior@tieto.com> Date: Mon, 9 May 2016 14:28:53 +0200 Message-ID: From: Michal Kazior To: linux-wireless Cc: Johannes Berg , Dave Taht , make-wifi-fast@lists.bufferbloat.net, codel@lists.bufferbloat.net, Avery Pennarun , Michal Kazior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-DomainID: tieto.com Subject: Re: [Make-wifi-fast] [PATCHv4 1/5] mac80211: skip netdev queue control with software queuing X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 12:28:54 -0000 On 5 May 2016 at 13:00, Michal Kazior wrote: [...] > -static void ieee80211_drv_tx(struct ieee80211_local *local, > - struct ieee80211_vif *vif, > - struct ieee80211_sta *pubsta, > - struct sk_buff *skb) > +static struct txq_info *ieee80211_get_txq(struct ieee80211_local *local, > + struct ieee80211_vif *vif, > + struct ieee80211_sta *pubsta, > + struct sk_buff *skb) > { > struct ieee80211_hdr *hdr =3D (struct ieee80211_hdr *) skb->data; > - struct ieee80211_sub_if_data *sdata =3D vif_to_sdata(vif); > struct ieee80211_tx_info *info =3D IEEE80211_SKB_CB(skb); > - struct ieee80211_tx_control control =3D { > - .sta =3D pubsta, > - }; > - struct ieee80211_txq *txq =3D NULL; > - struct txq_info *txqi; > - u8 ac; > > if ((info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) || > (info->control.flags & IEEE80211_TX_CTRL_PS_RESPONSE)) > - goto tx_normal; > + return NULL; > > if (!ieee80211_is_data(hdr->frame_control)) > - goto tx_normal; > + return NULL; > > if (pubsta) { > u8 tid =3D skb->priority & IEEE80211_QOS_CTL_TID_MASK; > > - txq =3D pubsta->txq[tid]; > + return to_txq_info(pubsta->txq[tid]); > } else if (vif) { > - txq =3D vif->txq; > + return to_txq_info(vif->txq); > } I just noticed this crashes on non-wake_tx_queue drivers. I'll re-spin a v5 with this fixed later. Micha=C5=82