From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DED203B2AE for ; Wed, 30 Mar 2016 05:22:52 -0400 (EDT) Received: by mail-wm0-x229.google.com with SMTP id p65so62336480wmp.0 for ; Wed, 30 Mar 2016 02:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=2PKFl/78erWCAAs6ndlS0i3NRm31CZ8GumnaDJ4wOso=; b=VXwf5TnYG4DCiEisjc5OTXjbv/9T6kVVdCp+A2GcFzCNwbi1abtRIXUUquGe//sidt aiX5noP5I32XdqXWCn1wOMvaE1Vqovz0L8qJtHhGisxCxIh/ygmZLGBaknEuxVZXYWwz HMqJM5Il3/wQr4CZ97PL9Rk5qbcr8zSEuZfNk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=2PKFl/78erWCAAs6ndlS0i3NRm31CZ8GumnaDJ4wOso=; b=eacTDzbCzIFCU+Z96ApURr3Zh9PvWo9rgPmmZMaLKIB1Iea7g2HZnK/w2b7eB4NmbH 0qevFen7yFBL/7FV+IcQLT76LVJ6fo/kWg4CKUIdtADiqip/ZbMnbIhBwYLnLiKSLZ+B dMIHTJPqOAF93NIkOlYLlCcsYrsp+qY+WvZUCnAVohI8tqelI57BseTMzK/IA69Rp3ka iXlr6DeEwAmGQzEvRU29JQ1QHJEPkSIOM8Er1anzSopTYFP5DV1NxCM/cXibgH0vfiAm +bb6ePujS8SyGoSBUV6WMZAom4tEca6dSqmgq9u6SvJ3dTsFs1cxQ65CSMN/wqfLGYge XVFw== X-Gm-Message-State: AD7BkJKePMZzqL/6TRXkETuvktA0vy6DD7uQP0qQVYycjnE1wwgPsnk4bAsgOB9GF/PFqEVa83C57QBHllqlsjRte79DwNaQKeMQdHdAb0f56i31w6E5DjkPNwp94gaMGwkQlNHAyZS5AJFdFcM88WzAoXTLCCGcQlp71A== MIME-Version: 1.0 X-Received: by 10.28.46.69 with SMTP id u66mr6013225wmu.98.1459329771925; Wed, 30 Mar 2016 02:22:51 -0700 (PDT) Received: by 10.194.115.3 with HTTP; Wed, 30 Mar 2016 02:22:51 -0700 (PDT) In-Reply-To: <56FAA518.2000805@candelatech.com> References: <1458898743-21118-1-git-send-email-michal.kazior@tieto.com> <56FAA518.2000805@candelatech.com> Date: Wed, 30 Mar 2016 11:22:51 +0200 Message-ID: From: Michal Kazior To: Ben Greear Cc: Dave Taht , "ath10k@lists.infradead.org" , linux-wireless , make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-DomainID: tieto.com Subject: Re: [Make-wifi-fast] [RFC] ath10k: implement dql for htt tx X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 09:22:53 -0000 On 29 March 2016 at 17:54, Ben Greear wrote: > On 03/29/2016 12:49 AM, Michal Kazior wrote: > >>> if you are getting a pure codel result of 160ms, that means the >>> implementation is broken. But I think (after having read your >>> description twice), the baseline result today of 160ms of queuing was >>> with a fq_codel *qdisc* doing the work on top of huge buffers, >> >> >> Yes. The 160ms is with fq_codel qdisc with ath10k doing DQL at 6mbps. >> Without DQL ath10k would clog up all tx slots (1424 of them) with >> frames. At 6mbps you typically want/need a handful (5-10) of frames to >> be queued. > > > Have you actually verified you can use all tx slots? It works in most cases. I guess you're suspecting some of your tx(flushing?) problems might be induced by overcommiting? > The way the > firmware uses it's tx buffers I think you may not be able to actually > do that...and in practice, you will get a lot fewer usable tx-buffers > than configured.... Could be, e.g. I'm aware management frames are kind of a special case in recent firmware revisions. What would/do you expect firmware would/will do when we overcommit? The driver does advertise number of HTT tx slots so I would expect it to work fine if it didn't crash during boot. Micha=C5=82