From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 538E03CB35 for ; Fri, 15 Nov 2019 19:10:50 -0500 (EST) Received: by mail-lj1-x244.google.com with SMTP id t5so12485719ljk.0 for ; Fri, 15 Nov 2019 16:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hxdT8dAYm8Ar1fpkfX22BBOhBL7JT8GOfO806iTzq+I=; b=P46VPMiXPQnDIZSr0Mg9WXW7xNxU2kLdKx5Uq1J99fogx12pexCMgdW+TUlitpBFIB MedZMIqq5I1NzQhpscpxCyQLUQu/oMVLTLxP9Ek/1X0F7KhcF+Bf5Qyb2yTIinvnr0u4 z9bmE/INIjY9NGtTNAph767xe8Rav5CewA2pnnWoqumicmYrsWSJSUctvMXdxfoJpZ3p Cs8O3oSFer6CBLWQkavc02/Qlrh6pgjh/I4SoHmaAWLlOHfwoN2V2FUNKMDqdcpOMfPF 3QIqJXJfM6j5aB2Rb5xP+SeXypTjUNE7DPuLMpYEbgcGAL/QON5SkC246QKqVnxINt82 TutA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hxdT8dAYm8Ar1fpkfX22BBOhBL7JT8GOfO806iTzq+I=; b=oGSWsTw095s6uS9UDXFkoTV5zkEYgst4xbzP/Xe+9M1BCbgMVqekPltua27HJOAgn2 kNLdLkfUVqQZ92Z7du9JwxhrqmbYDOtPkrCrk2aOKEOv3WbAEwdydgiAjYQ+okNdXzYW VPlMBtV8dtgDBoHMv9qi4VScifnA9IVzBnPeWwwqxBD2yFmpbF7iz30zm7ZukMwNLUuI gNvGpRMEV98H5/MQuNddrBRIc/gN635qOUfPk/hlvuU+irmNrpskTjQQfMYCJXiyjwxu AZvqTLcMUPMKSpfDbZNYO5DdzcNN5QaZWjKiMiJg1h4jz0cD5XM6SvsmuvOrB0l/fqNX Y2WA== X-Gm-Message-State: APjAAAWQbdv3zVoXWDqJcFkJf1zxD4f/tiwSyN9+HPKVn0sSyOJS24i/ dQPiowzQvSh7Aps8Uk0wFFIavGXKb8SgP+3WdgO7tA== X-Google-Smtp-Source: APXvYqw7OaATil1l8kLW7C8e/zkxRTzG/nWxyGnil7gmnu8C05UFl+o8T8LRuodvXvsKrjfx83Y3+D/Srp+2YA/6Swg= X-Received: by 2002:a2e:9904:: with SMTP id v4mr7282007lji.211.1573863048724; Fri, 15 Nov 2019 16:10:48 -0800 (PST) MIME-Version: 1.0 References: <20191115014846.126007-1-kyan@google.com> In-Reply-To: From: Kan Yan Date: Fri, 15 Nov 2019 16:10:37 -0800 Message-ID: To: Dave Taht Cc: Johannes Berg , Rajkumar Manoharan , Kevin Hayes , Make-Wifi-fast , linux-wireless , Yibo Zhao , John Crispin , Lorenzo Bianconi , Felix Fietkau Content-Type: multipart/alternative; boundary="000000000000f24b6705976b8b07" Subject: Re: [Make-wifi-fast] [PATCH v8 0/2] Implement Airtime-based Queue Limit (AQL) X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2019 00:10:50 -0000 --000000000000f24b6705976b8b07 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > I do keep hoping for pretty pictures. Got any? :-P Certainly! I do have some :). Here is the link: https://drive.google.com/corp/drive/folders/14OIuQEHOUiIoNrVnKprj6rBYFNZ0Co= if > > Is there an ax QCAXXXX platform, m.2 card, or mini-pci card worth > testing at this point? It will be great if someone with 11.ax platform can help give it a try. > How are they handling mu-mimo? I think it should still work. The queue length in airtime for each individual queue is unchanged, even the multiple queues are allowed to transmit concurrently with mu-mimo. I have a round of tests scheduled for intel's ax200 chips, soon. Not sure > what, if any, of this new work might apply. It will be very interesting to know how it performance on 802.11ax platforms. Supposedly 802.11ax already fixed the latency problem so the benefit of this patch should be less significant. On Thu, Nov 14, 2019 at 6:07 PM Dave Taht wrote: > On Thu, Nov 14, 2019 at 6:04 PM Kan Yan wrote: > > > > I have tested it with Toke's patch "[PATCH v6 4/4] mac80211: Use > > Airtime-based Queue Limits (AQL) on packet dequeue", but didn't > > include it here, as it is self contained and Toke has plan to update > > it. > > > > The platform (QCA9984) used in my test > > I do keep hoping for pretty pictures. Got any? :-P > > > doesn't support 802.11ax, so I > > was not able to test the HE mode support added in v7 update of "Import > > airtime calculation code from mt76" from Toke. > > Is there an ax QCAXXXX platform, m.2 card, or mini-pci card worth > testing at this point? > > How are they handling mu-mimo? > > I have a round of tests scheduled for intel's ax200 chips, soon. Not sure > what, if any, of this new work might apply. > > > On Thu, Nov 14, 2019 at 5:48 PM Kan Yan wrote: > > > > > > This patch series port the Airtime Queue Limits concept from the > out-of-tree > > > ath10k implementation[0] to mac80211. This version takes my patch to > do the > > > throttling in mac80211, and replaces the driver API with the mechanis= m > from > > > Toke's series, which instead calculated the expected airtime at > dequeue time > > > inside mac80211, storing it in the SKB cb field. > > > > > > This version has been tested on QCA9984 platform. > > > > > > [0] > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/= +/1703105/7 > > > > > > Changelog: > > > > > > v8: > > > - Includes Toke's v7 version of "mac80211: Import airtime > calculation code from mt76" > > > - Don't clobber sta's customized queue limit when configuring the > default via debugfs > > > - Fix a racing condition when reset aql_tx_pending. > > > > > > v7: > > > - Fix aql_total_pending_airtime underflow due to insufficient > locking. > > > > > > v6: > > > - Fix sta lookup in ieee80211_report_used_skb(). > > > - Move call to ieee80211_sta_update_pending_airtime() to a bit late= r > in > > > __ieee80211_tx_status() > > > v5: > > > - Add missing export of ieee80211_calc_rx_airtime() and make > > > ieee80211_calc_tx_airtime_rate() static (kbuildbot). > > > - Use skb_get_queue_mapping() to get the AC from the skb. > > > - Take basic rate configuration for the BSS into account when > calculating > > > multicast rate. > > > v4: > > > - Fix calculation that clamps the maximum airtime to fit into 10 bi= ts > > > - Incorporate Rich Brown's nits for the commit message in Kan's pat= ch > > > - Add fewer local variables to ieee80211_tx_dequeue() > > > v3: > > > - Move the tx_time_est field so it's shared with ack_frame_id, and > use units > > > of 4us for the value stored in it. > > > - Move the addition of the Ethernet header size into > ieee80211_calc_expected_tx_airtime() > > > v2: > > > - Integrate Kan's approach to airtime throttling. > > > - Hopefully fix the cb struct alignment on big-endian architectures= . > > > > > > > > > > > > Kan Yan (1): > > > mac80211: Implement Airtime-based Queue Limit (AQL) > > > > > > Toke H=C3=B8iland-J=C3=B8rgensen (1): > > > mac80211: Import airtime calculation code from mt76 > > > > > > include/net/cfg80211.h | 7 + > > > include/net/mac80211.h | 41 +++ > > > net/mac80211/Makefile | 3 +- > > > net/mac80211/airtime.c | 597 +++++++++++++++++++++++++++++++++++= ++ > > > net/mac80211/debugfs.c | 85 ++++++ > > > net/mac80211/debugfs_sta.c | 43 ++- > > > net/mac80211/ieee80211_i.h | 8 + > > > net/mac80211/main.c | 10 +- > > > net/mac80211/sta_info.c | 38 +++ > > > net/mac80211/sta_info.h | 8 + > > > net/mac80211/tx.c | 47 ++- > > > 11 files changed, 872 insertions(+), 15 deletions(-) > > > create mode 100644 net/mac80211/airtime.c > > > > > > -- > > > 2.24.0.rc1.363.gb1bccd3e3d-goog > > > > > _______________________________________________ > > Make-wifi-fast mailing list > > Make-wifi-fast@lists.bufferbloat.net > > https://lists.bufferbloat.net/listinfo/make-wifi-fast > > > > -- > > Dave T=C3=A4ht > CTO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-831-205-9740 <(831)%20205-9740> > --000000000000f24b6705976b8b07 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> I do keep hoping for pretty pictures. Got any? :-P
Certainly! I do have some :). Here is the link:
http= s://drive.google.com/corp/drive/folders/14OIuQEHOUiIoNrVnKprj6rBYFNZ0Coif

>
> Is there an ax QCAXXXX platform, m.2 card, or mini-p= ci card worth
> testing at this point?

It will be great if som= eone with 11.ax platform can help give it a tr= y.

> How are they handling mu-mimo?

I think it should stil= l work. The queue length in airtime for each individual queue is unchanged,= even the multiple queues are allowed to transmit concurrently with mu-mimo= .

I have a round o= f tests scheduled for intel's ax200 chips, soon. Not sure
what, if a= ny, of this new work might apply.
It will be very interest= ing to know how it performance on 802.11ax platforms. Supposedly 802.11ax a= lready fixed the latency problem so the benefit=C2=A0of this patch should b= e less significant.


On Thu, Nov 14, 2019 at 6:07 PM Dave Taht <= ;dave.taht@gmail.com> wrote:<= br>
On Thu, Nov 14, = 2019 at 6:04 PM Kan Yan <kyan@google.com> wrote:
>
> I have tested it with Toke's patch "[PATCH v6 4/4] mac80211: = Use
> Airtime-based Queue Limits (AQL) on packet dequeue", but didn'= ;t
> include it here, as it is self contained and Toke has plan to update > it.
>
> The platform (QCA9984) used in my test

I do keep hoping for pretty pictures. Got any? :-P

>=C2=A0 doesn't support 802.11ax, so I
> was not able to test the HE mode support added in v7 update of "I= mport
> airtime calculation code from mt76" from Toke.

Is there an ax QCAXXXX platform, m.2 card, or mini-pci card worth
testing at this point?

How are they handling mu-mimo?

I have a round of tests scheduled for intel's ax200 chips, soon. Not su= re
what, if any, of this new work might apply.

> On Thu, Nov 14, 2019 at 5:48 PM Kan Yan <kyan@google.com> wrote:
> >
> > This patch series port the Airtime Queue Limits concept from the = out-of-tree
> > ath10k implementation[0] to mac80211. This version takes my patch= to do the
> > throttling in mac80211, and replaces the driver API with the mech= anism from
> > Toke's series, which instead calculated the expected airtime = at dequeue time
> > inside mac80211, storing it in the SKB cb field.
> >
> > This version has been tested on QCA9984 platform.
> >
> > [0] ht= tps://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/17= 03105/7
> >
> > Changelog:
> >
> > v8:
> >=C2=A0 =C2=A0- Includes Toke's v7 version of "mac80211: I= mport airtime calculation code from mt76"
> >=C2=A0 =C2=A0- Don't clobber sta's customized queue limit = when configuring the default via debugfs
> >=C2=A0 =C2=A0- Fix a racing condition when reset aql_tx_pending. > >
> > v7:
> >=C2=A0 =C2=A0- Fix aql_total_pending_airtime underflow due to insu= fficient locking.
> >
> > v6:
> >=C2=A0 =C2=A0- Fix sta lookup in ieee80211_report_used_skb().
> >=C2=A0 =C2=A0- Move call to ieee80211_sta_update_pending_airtime()= to a bit later in
> >=C2=A0 =C2=A0 =C2=A0__ieee80211_tx_status()
> > v5:
> >=C2=A0 =C2=A0- Add missing export of ieee80211_calc_rx_airtime() a= nd make
> >=C2=A0 =C2=A0 =C2=A0ieee80211_calc_tx_airtime_rate() static (kbuil= dbot).
> >=C2=A0 =C2=A0- Use skb_get_queue_mapping() to get the AC from the = skb.
> >=C2=A0 =C2=A0- Take basic rate configuration for the BSS into acco= unt when calculating
> >=C2=A0 =C2=A0 =C2=A0multicast rate.
> > v4:
> >=C2=A0 =C2=A0- Fix calculation that clamps the maximum airtime to = fit into 10 bits
> >=C2=A0 =C2=A0- Incorporate Rich Brown's nits for the commit me= ssage in Kan's patch
> >=C2=A0 =C2=A0- Add fewer local variables to ieee80211_tx_dequeue()=
> > v3:
> >=C2=A0 =C2=A0- Move the tx_time_est field so it's shared with = ack_frame_id, and use units
> >=C2=A0 =C2=A0 =C2=A0of 4us for the value stored in it.
> >=C2=A0 =C2=A0- Move the addition of the Ethernet header size into = ieee80211_calc_expected_tx_airtime()
> > v2:
> >=C2=A0 =C2=A0- Integrate Kan's approach to airtime throttling.=
> >=C2=A0 =C2=A0- Hopefully fix the cb struct alignment on big-endian= architectures.
> >
> >
> >
> > Kan Yan (1):
> >=C2=A0 =C2=A0mac80211: Implement Airtime-based Queue Limit (AQL) > >
> > Toke H=C3=B8iland-J=C3=B8rgensen (1):
> >=C2=A0 =C2=A0mac80211: Import airtime calculation code from mt76 > >
> >=C2=A0 include/net/cfg80211.h=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A07 +=
> >=C2=A0 include/net/mac80211.h=C2=A0 =C2=A0 =C2=A0|=C2=A0 41 +++ > >=C2=A0 net/mac80211/Makefile=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A03 += -
> >=C2=A0 net/mac80211/airtime.c=C2=A0 =C2=A0 =C2=A0| 597 +++++++++++= ++++++++++++++++++++++++++
> >=C2=A0 net/mac80211/debugfs.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 85 ++++++=
> >=C2=A0 net/mac80211/debugfs_sta.c |=C2=A0 43 ++-
> >=C2=A0 net/mac80211/ieee80211_i.h |=C2=A0 =C2=A08 +
> >=C2=A0 net/mac80211/main.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 10 += -
> >=C2=A0 net/mac80211/sta_info.c=C2=A0 =C2=A0 |=C2=A0 38 +++
> >=C2=A0 net/mac80211/sta_info.h=C2=A0 =C2=A0 |=C2=A0 =C2=A08 +
> >=C2=A0 net/mac80211/tx.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0= 47 ++-
> >=C2=A0 11 files changed, 872 insertions(+), 15 deletions(-)
> >=C2=A0 create mode 100644 net/mac80211/airtime.c
> >
> > --
> > 2.24.0.rc1.363.gb1bccd3e3d-goog
> >
> _______________________________________________
> Make-wifi-fast mailing list
> Make-wifi-fast@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/ma= ke-wifi-fast



--

Dave T=C3=A4ht
CTO, TekLibre, LLC
ht= tp://www.teklibre.com
Tel: 1-831-205-9740
--000000000000f24b6705976b8b07--