From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4CFD33B29E for ; Wed, 23 Oct 2019 02:42:00 -0400 (EDT) Received: by mail-lj1-x242.google.com with SMTP id n14so19777788ljj.10 for ; Tue, 22 Oct 2019 23:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xLzPgNOZ8X14gfCEvYWsxDF01OFUZfoQjcWDyuoGltc=; b=LJWHaiQc/q6Hg9z63NPV0MjMzWfOhKO0ey++fb4OkDyjZxD45pVUtUWBaO1/A2Qw2d RJd7oMRFkK9acDzP60fuBo6rXfXFDBhRQNsaSsYvkYETY+Y//R9nqZUBljNNONlm2JRJ fA/4lfnnSbauy8m0CvVAUs+97DA1Lf3yvlh2Ek0wox9gA1zBdoGbHsm6eJ5bUAmzQbNq +CZzAgGbM6Pffjp8WhndhgV/FPWBbAZP77u09c6zMgkfR77ity9Rx2DfjWwUpJsmAL1g TDWItxlH08H4EGtDcM+O35SFI3kDJZEl/vvqCBaLjWr7MkbwhQW3690smPgjvwVTpcrg pThA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xLzPgNOZ8X14gfCEvYWsxDF01OFUZfoQjcWDyuoGltc=; b=dN+JW46v2nGJPuRaBNF1Frj+Gv2A/A2xSKVL8FXeMt2w2gxRDrPP0Wv9Uh69fbngFp 5cEW8jxn2sZk7K7XQrSWtjQ22O7IaBeyuf70x2DJd8/kVMfdiMlejr+6nBJVyNcXg/sa 4hulGqW6MF4bG16+sQ7CMLjKNoQKGTZHtYwNLIhR8xAYPnvHBQvXlnuUSXZ0/gBxIjTE p+icLTz5fTmCKDLuuGAH3qjdk2ock+y5blXZ/PX3Vyvgl+UwA9aj5eVtNTbk72AmIaS3 JsGyoxhhJdxH7yRG4/KWlbh+1Y4iVMuz4xQv/q7j5yKP1kNeDlcWA+9faD3U33UwHT1p J96w== X-Gm-Message-State: APjAAAW7XKv62ockBppTf5Zocml9r/8Gjy7gBO7u5H4cczRTz0FOunZZ d57IwMXtOaHkXG8KqopdTMsjA/j+gt0LE7tu6R31tw== X-Google-Smtp-Source: APXvYqwbYShriZrtOfH5CKHMRI9ZjT56L9KXRHcmYVKve8FvpLfX1msZDukO1Wkvr96pb24xb7V1qDQkpFKWU15F9BQ= X-Received: by 2002:a2e:9759:: with SMTP id f25mr21512398ljj.173.1571812918369; Tue, 22 Oct 2019 23:41:58 -0700 (PDT) MIME-Version: 1.0 References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> <871rv5ovwr.fsf@toke.dk> In-Reply-To: <871rv5ovwr.fsf@toke.dk> From: Kan Yan Date: Tue, 22 Oct 2019 23:41:47 -0700 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2019 06:42:00 -0000 > >> + if (ieee80211_is_data_qos(hdr->frame_control)) { > >> + qc =3D ieee80211_get_qos_ctl(hdr); > >> + tid =3D qc[0] & 0xf; > >> + ac =3D ieee80211_ac_from_tid(tid); > >> + } else { > >> + ac =3D IEEE80211_AC_BE; > >> + } > > > > The tid/ac is incorrect either here or in __ieee80211_tx_status() when > > tested with ath10k. The ac is set to AC_BE with test done using BK > > class traffic, hence the pending airtime get updated for the wrong > > txq. > > Huh, well that won't do, obviously :) > > Any idea why it might be wrong? somehow ieee80211_is_data_qos() returns false. Besides, qos_control field doesn't seems to be set in ieee80211_build_hdr(). > Hmm, I guess we could just get the ac using skb_get_queue_mapping(). > I'll send an update with this fixed for you to try :) Thanks for the quick update. It is getting much better, but unfortunately the pending airtime accounting sometimes is still not correct and cause txq stuck occasionally. On Tue, Oct 22, 2019 at 4:35 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Kan Yan writes: > > >> + if (ieee80211_is_data_qos(hdr->frame_control)) { > >> + qc =3D ieee80211_get_qos_ctl(hdr); > >> + tid =3D qc[0] & 0xf; > >> + ac =3D ieee80211_ac_from_tid(tid); > >> + } else { > >> + ac =3D IEEE80211_AC_BE; > >> + } > > > > The tid/ac is incorrect either here or in __ieee80211_tx_status() when > > tested with ath10k. The ac is set to AC_BE with test done using BK > > class traffic, hence the pending airtime get updated for the wrong > > txq. > > Hmm, I guess we could just get the ac using skb_get_queue_mapping(). > I'll send an update with this fixed for you to try :) > > -Toke >