From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4479E3CB35 for ; Mon, 14 Oct 2019 19:58:17 -0400 (EDT) Received: by mail-lj1-x241.google.com with SMTP id m7so18306251lji.2 for ; Mon, 14 Oct 2019 16:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JPvtAhVgHaqjs/EQbN+HHGKZb04AFtR23CWG2J/pYzg=; b=BJXFZaoaOEFudxdPwrAxofTfRLkpnPWPJeiWWKuTGp6VJoxGBpbQIwoa9yAw0ETpOR fUqWkUB2yKwREvl4aFh7E8dCUd6uvQa5j1M2ajhez0YC4t84HRFKrFMGe2CJ1HLyRgHe t1sAvNxmPRGMV4GaVU+YX30tBlmyR3YL8Yqrm4WsB+cSLCFQ4nwqEr7JvxJQVSjabjsI 7mxRSVQrdLcw/VX4JDXWFPEu8u65ca8Ton/fO/Q6WwuzB0Nao6fkqz7hu1ToXUnAar2s NuQW/zAS16U3yKH4rdjaPOUo8Hto0zkaiRbCgOyxZO2l8fdfLDDCoOzUVtvz5UILL+X3 0GMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JPvtAhVgHaqjs/EQbN+HHGKZb04AFtR23CWG2J/pYzg=; b=f5wVBn82oGxt950Mt09UffhEwSk+ZXvsZYnJHPNNTSxx5KxvCqdjUvfB+NerzoK47w Ud73gDfLYA/drBDlTmBWi8KjQ9RElW4+Xf+jn+gXJyubv6AoWMQbILVWr0YixpnGjASi RbTJQgVRYpk3185PwXToaByEiSKimJk2+pKqGeV+Sb1aF0Pc3wjye3TYsSTG3W9PBIfJ PQjGxh1O86Ie027GCHVkY4cDL1uyouYOWu9l9srjKca74tdDac7wBMqsHr/UkWggE17F 3kYYh9yzksgVYfXXHEJ2cF2S6EoCvvEtE1YhDaBYpkItYWcxwqtk9ccd6k6M/3L8t76z 6Zww== X-Gm-Message-State: APjAAAWtYJBsh2btUn737qUWPBz+V9jGXstVGz1gsGHO1XCkyiwsZfQe g0fYxfVNNlXrO8XDCl8N1XqAzDHpZn5EyV7wBrPrYw== X-Google-Smtp-Source: APXvYqwTYFbJV9swRZOOCbryRgaI72elPIj0s6C4+0Lirr86n5yZSHudIeTWAaUCYwEcefjmsTfd0Zn00oPouTLhXtQ= X-Received: by 2002:a2e:9759:: with SMTP id f25mr9634973ljj.173.1571097495738; Mon, 14 Oct 2019 16:58:15 -0700 (PDT) MIME-Version: 1.0 References: <20191011022413.176208-1-kyan@google.com> <87wod7y9ui.fsf@kamboji.qca.qualcomm.com> <87sgnvy9c2.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87sgnvy9c2.fsf@kamboji.qca.qualcomm.com> From: Kan Yan Date: Mon, 14 Oct 2019 16:58:04 -0700 Message-ID: To: Kalle Valo Cc: make-wifi-fast@lists.bufferbloat.net, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Yibo Zhao , Johannes Berg , Felix Fietkau Content-Type: text/plain; charset="UTF-8" Subject: Re: [Make-wifi-fast] [PATCH v4 0/2] Implement Airtime-based Queue Limit (AQL) X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Oct 2019 23:58:17 -0000 Hi Kalle, Thanks for the help and tips. Will do that if I need to submit again. I believe Toke will integrate this with his version and move the estimating pending airtime part to mac80211, so maybe in the next version, ath10k change is no longer required. Thanks, Kan On Mon, Oct 14, 2019 at 2:18 AM Kalle Valo wrote: > > Kalle Valo writes: > > > Kan Yan writes: > > > >> This patch series implements Airtime-based Queue Limit (AQL) in the > >> mac80211 and Ath10k driver. It is based on an earlier version from > >> the ChromiumOS tree[0]. > >> > >> This version has been tested with QCA9884 platform with 4.14 kernel. > >> Tests show AQL is able to reduce latency by an order of magnitude in > >> a congested environment without negative impact on the throughput. > >> > >> [0] > >> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1703105/7 > >> > >> Kan Yan (2): > >> mac80211: Implement Airtime-based Queue Limit (AQL) > >> ath10k: Enable Airtime-based Queue Limit (AQL) > > > > Please always include a change log so that people know what has changed > > since the previous version: > > > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing > > Never mind, you actually had the changelog after the signature separator > ("-- \n" line) and I automatically skip the signature :) So instead I > recommend moving the change log up and above the signature separator. > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches