From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CA9FE3B2A4 for ; Wed, 9 Oct 2019 22:35:19 -0400 (EDT) Received: by mail-lj1-x241.google.com with SMTP id m13so4487811ljj.11 for ; Wed, 09 Oct 2019 19:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xNOk7RHs2NX231yJ4vn1jUbJI6Vg12VmhwZvxDf3llU=; b=BxwrlrJYW5KCzwrH2ymFZOFiqA2U16Y9AQbAkSScJraAZWewvUSoi9Ur+Fj0oUwxYu yHKfU0MOzjkOE9iFBJoQo8FjrMsRyzTOaLL5FaquJCpEdqbvf8Lsdr6uDcIuBhOKwKCv s5o2RnleG5+7V9L6BmuhPwMx1uzCXVxQUacrrtUSMEoVtO++6pKdKXh0CS6D5848f8bk pks1O/Gv2cmp80L3fWyivc8UbwEEA+kPcq2ypPlKwkM6BbGf4ZVwyjpSZLTJ5gUv1yX7 YQ+Z96xnKURYMB6ar5vXhRGK4avzaY0P32RIQoKONyEHVcSnzeVqm4jLuC9ra/uTmUa0 iZCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xNOk7RHs2NX231yJ4vn1jUbJI6Vg12VmhwZvxDf3llU=; b=eiEFpuPxZyO80QC9s8+SQdEymbfVYRZxyvNvHz4qP6ytzeqtmNxRMfPOgXWtSgIjID 7zDC3XytBdxEYcB0L0bPdUxiJLIo0adpbN+O7fpRszXMSiZr76LXN4IdU4vYrU6YuLuD PYzdUA1Ncz44+WPqgTXKFsk6SaKBD94M8iW0EXJATLQVvwF/6f9CuNR5PS6HR7768M3R K98NtiJYsYsZIcYdyTk1xPprwhg5x3iDBDtWkGAtePptoCY/IofKomaEhPqHunl4P/Gr LFkaXXvS/Vol3PZC4j+QKigvBO6QPkBjFICwwPmyCVsjnVQWzQtLR39cNpoNZ7z+TDDW TMtQ== X-Gm-Message-State: APjAAAWRIvK7wyhnfsSJtSxy9CF5ij7ORfOY/FrQgV/8yW02wmxWFn8e KVojt+HJCpKxclY6fIEOmRfzdM2/c08IOHOqy6Zj3Q== X-Google-Smtp-Source: APXvYqwwrdPan2+uHY+XBfFTybHUsvN8bh1ZbFKWi6AkQkilSDfV/jCIK6QipEjOGXZh5r2z8+XgmGx6kLQOYqbGUcE= X-Received: by 2002:a05:651c:112e:: with SMTP id e14mr4229753ljo.193.1570674918128; Wed, 09 Oct 2019 19:35:18 -0700 (PDT) MIME-Version: 1.0 References: <20191004062151.131405-1-kyan@google.com> <20191004062151.131405-2-kyan@google.com> <87imp4o6qp.fsf@toke.dk> <87pnj9n55y.fsf@toke.dk> <878spwmjif.fsf@toke.dk> <600f64e1e673fff25d2be71ac767d7332db0452a.camel@sipsolutions.net> In-Reply-To: <600f64e1e673fff25d2be71ac767d7332db0452a.camel@sipsolutions.net> From: Kan Yan Date: Wed, 9 Oct 2019 19:35:06 -0700 Message-ID: To: Johannes Berg Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, Felix Fietkau , Yibo Zhao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH 1/2] mac80211: Implement Airtime-based Queue Limit (AQL) X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Oct 2019 02:35:20 -0000 > I'd like to use the new rate calculation code that Felix added to mt76. > Is the arsta->txrate info in ath10k suitable to be passed up to mac80211 > and used in that, do you think? Because then that would probably be the > easiest way to go about it... Do you mean the mt76 patch that using the EWMA to smooth estimate data rate? It would be great if you can move that to mac80211. Yes, arsta->txrate info in ath10k is a good place to extract latest date ra= te. On Mon, Oct 7, 2019 at 12:43 PM Johannes Berg w= rote: > > On Mon, 2019-10-07 at 21:40 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : > > > > > So if and when we start supporting true multi-band devices we'll ha= ve to > > > > change these things anyway. So might as well keep everything togeth= er so > > > > it all gets fixed :) > > > > > > I guess I'm OK with that, but I'm pretty sure this will come up soone= r > > > rather than later ... > > > > > > What else is there though? > > > > By "it all" I meant "all the airtime fairness stuff". Other than that, = I > > didn't have anything in particular in mind. I just kinda assumed there > > would be lots of places that had an implicit assumption that all device= s > > on the same phy shares a channel... > > Not _that_ much - we do have the channel contexts after all. But except > for hwsim (*cough cough* I was lazy) nothing actually implements real > concurrent multi-channel yet, obviously, but uses a single radio with > channel hopping... > > johannes >